From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id B5FEC7CAF for ; Thu, 7 Apr 2016 18:46:49 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay1.corp.sgi.com (Postfix) with ESMTP id 6D6768F8049 for ; Thu, 7 Apr 2016 16:46:49 -0700 (PDT) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id q9OuJ3CtmXRFXnAr (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Thu, 07 Apr 2016 16:46:46 -0700 (PDT) Date: Thu, 7 Apr 2016 16:46:36 -0700 From: Christoph Hellwig Subject: Re: [PATCH 6/6] xfs: mark reclaimed inodes invalid earlier Message-ID: <20160407234636.GC26634@infradead.org> References: <1460072271-23923-1-git-send-email-david@fromorbit.com> <1460072271-23923-7-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1460072271-23923-7-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com > + spin_lock(&ip->i_flags_lock); > + ip->i_flags = XFS_IRECLAIM; > + ip->i_ino = 0; > + spin_unlock(&ip->i_flags_lock); It's just a tiny sniplet, but still duplicated from xfs_inode_free(). Maybe add another helper for this? Otherwise looks fine: Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs