public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: Use latest xfs_repair on older file systems
Date: Sat, 9 Apr 2016 08:27:42 +1000	[thread overview]
Message-ID: <20160408222742.GC567@dastard> (raw)
In-Reply-To: <5708194D.4080406@sandeen.net>

On Fri, Apr 08, 2016 at 03:49:17PM -0500, Eric Sandeen wrote:
> Obsolete features do occasionally get dropped upstream, as well - witness
> your V1 inode message.  However, that was likely just some other form of
> corruption, seen as V1 inodes, unless this really was a very, very old
> filesystem (created prior to 2007), which seems unlikely.

That error does not come from inode number checking - it is emitted
if the NLINK feature bit is missing from the superblock feature
field.

> On 4/8/16 3:37 PM, Chris M Moser wrote:
> I unmounted and ran xfs_repair 2.9.4 form the host OS a few more
> times.

Is this filesystem was created with 2.9.4, we're talking about a
filesystem that was released:

xfsprogs-2.9.4 (7 Sep 2007)

And, importantly:

xfsprogs-2.9.5 (21 Jan 2008)
        - Updated mkfs.xfs defaults.

It was then very next release that sets NLINK by default via:

commit 8d537733f52a642d471f6781f32f306241dd4308
Author: Niv Sardi <xaiki@sgi.com>
Date:   Fri Nov 16 05:16:34 2007 +0000
....
    -
    V2 inodes per default, and move DFL bits to XFS_DFL_SB_VERSION_BITS,

    Activate XFS_SB_VERSION_NLINKBIT per default, which will enable V2 INODES.
    refactor bits that we want everytime in XFS_DFL_SB_VERSION_BITS.
    -
....


So, your host has the very last version of xfsprogs that defaulted
to v1 inodes, and so recent xfsprogs versions will simply refuse to
run on it. It does not imply there is any corruption, however, you
just need to use a version of xfs_repair that supports v1 inodes...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-04-08 22:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 20:37 Use latest xfs_repair on older file systems Chris M Moser
2016-04-08 20:49 ` Eric Sandeen
2016-04-08 22:27   ` Dave Chinner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-04-11 17:15 Chris M Moser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160408222742.GC567@dastard \
    --to=david@fromorbit.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox