From: Dave Chinner <david@fromorbit.com>
To: Shyam Kaushik <shyam@zadarastorage.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Abort intent log item in xfs_iflush() upon error to get buf
Date: Wed, 13 Apr 2016 07:16:19 +1000 [thread overview]
Message-ID: <20160412211619.GK567@dastard> (raw)
In-Reply-To: <5e9c99552ae829dce9eb574d72085323@mail.gmail.com>
On Tue, Apr 12, 2016 at 11:10:13PM +0530, Shyam Kaushik wrote:
> Hi Dave,
>
> Your patch needs a minor correction.
>
> At start of xfs_iflush() either we must initialize "bp = NULL" or else
> xfs_imap_to_bp() when it hits an error need to set "*bpp = NULL".
> Otherwise with your patch we are having an uninitialized bp that
> corrupt_out is trying to do xfs_buf_relse().
Ok, I'll check that - I thought that xfs_trans_buf_read_map() was
initialising it to zero appropriately, but obviously I missed
something.
Thanks for testing!
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-04-12 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 6:57 [PATCH] xfs: Abort intent log item in xfs_iflush() upon error to get buf Shyam Kaushik
2016-04-12 8:28 ` Dave Chinner
2016-04-12 11:47 ` Shyam Kaushik
2016-04-12 17:40 ` Shyam Kaushik
2016-04-12 21:16 ` Dave Chinner [this message]
2016-04-13 4:02 ` Shyam Kaushik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412211619.GK567@dastard \
--to=david@fromorbit.com \
--cc=shyam@zadarastorage.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox