From: Dave Chinner <david@fromorbit.com>
To: Alex Lyakas <alex@zadarastorage.com>
Cc: bbice@sgi.com, Shyam Kaushik <shyam@zadarastorage.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 4/5] xfs: xfs_inode_free() isn't RCU safe
Date: Wed, 13 Apr 2016 09:29:25 +1000 [thread overview]
Message-ID: <20160412232925.GN567@dastard> (raw)
In-Reply-To: <0A92B65A3BF94F60BB36EA3FA716DF1F@alyakaslap>
On Tue, Apr 12, 2016 at 11:56:35AM +0300, Alex Lyakas wrote:
> Hello Dave,
>
> Looking at the patch, I see that now we call xfs_idestroy_fork() in RCU callback. This can do the following chain:
>
> xfs_iext_destroy => xfs_iext_irec_remove => xfs_iext_realloc_indirect=> kmem_realloc => kmem_alloc => kmem_alloc => congestion_wait()
>
> At least according to documentation, the RCU callback cannot block, since it may be called from softirq context. Is this fine?
Right, I forgot about that. Too many forests. I'll reconstruct your
patch from the email you appended it to previously and add that to
the series to test against.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-04-12 23:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 8:56 [PATCH 4/5] xfs: xfs_inode_free() isn't RCU safe Alex Lyakas
2016-04-12 11:29 ` Brent Bice
2016-04-12 21:11 ` Dave Chinner
2016-04-12 21:55 ` Brent Bice
2016-04-12 23:29 ` Dave Chinner [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-12 8:55 Alex Lyakas
2016-04-06 9:22 [PATCH 0/5] xfs; xfs_iflush_cluster vs xfs_reclaim_inode Dave Chinner
2016-04-06 9:22 ` [PATCH 4/5] xfs: xfs_inode_free() isn't RCU safe Dave Chinner
2016-04-07 15:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412232925.GN567@dastard \
--to=david@fromorbit.com \
--cc=alex@zadarastorage.com \
--cc=bbice@sgi.com \
--cc=shyam@zadarastorage.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox