From: Dave Chinner <david@fromorbit.com>
To: Shyam Kaushik <shyam@zadarastorage.com>
Cc: Alex Lyakas <alex@zadarastorage.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_buf_iodone_callbacks to force shutdown & resubmit buf in case of permanent failure
Date: Thu, 28 Apr 2016 09:53:15 +1000 [thread overview]
Message-ID: <20160427235315.GL26977@dastard> (raw)
In-Reply-To: <cbaec1d0ddb8505a9d35084291d33f37@mail.gmail.com>
On Wed, Apr 27, 2016 at 10:29:29AM +0530, Shyam Kaushik wrote:
> Hi Dave,
>
> I am not sure how to do lock release in this code path. Is it possible
> that you can take over this bug/patch? Thanks.
To tell the truth, I haven't even thought about how to fix it yet.
I suspect that the callbacks will need to be run, but with a new
parameter passed to xfs_iflush_done to say "still dirty, unlock
only" so that it simply unlocks and removes each object from the
buffer callback list.
I've got other things that need my attention right now (e.g agfl
size problem), so it's going to be next week before I get to this...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-04-27 23:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 14:01 [PATCH] xfs_buf_iodone_callbacks to force shutdown & resubmit buf in case of permanent failure Shyam Kaushik
2016-04-26 22:46 ` Dave Chinner
2016-04-27 4:59 ` Shyam Kaushik
2016-04-27 23:53 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427235315.GL26977@dastard \
--to=david@fromorbit.com \
--cc=alex@zadarastorage.com \
--cc=shyam@zadarastorage.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox