Re: [PATCH 03/19] mkfs: Sanitise the superblock feature macros

Eric Sandeen
2016-05-02T23:06:51Z

Patch 03/19 fixup:

sb_feat.dirftype should be initialized as true, not initialized
as false and then reset to 1 (sic - true)

Eric Sandeen <sandeen@redhat.com>: Properly initialize sb_feat.dirftype
---

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 963545b..655b3c0 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -1090,7 +1090,7 @@ main(
.lazy_sb_counters = true,
.projid16bit = false,
.crcs_enabled = true,
- .dirftype = false,
+ .dirftype = true,
.parent_pointers = false,
};

@@ -1109,7 +1109,6 @@ main(
liflag = laflag = lsflag = lsuflag = lsunitflag = ldflag = lvflag = 0;
loginternal = 1;
logagno = logblocks = rtblocks = rtextblocks = 0;
- sb_feat.dirftype = 1; /* inode type information in the dir */
Nflag = nlflag = nsflag = nvflag = 0;
nftype = 0;
dirblocklog = dirblocksize = 0;