Re: [PATCH 03/19] mkfs: Sanitise the superblock feature macros

Eric Sandeen
2016-05-04T00:48:47Z

Patch 03/19 fixup V2:

sb_feat.dirftype should be initialized as true, not initialized
as false and then reset to 1 (sic - true)

V2: Remove unnecessary continuation chars "\"

Eric Sandeen <sandeen@redhat.com>: Properly initialize sb_feat.dirftype
---

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 963545b..e19181c 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -975,8 +975,7 @@ sb_set_features(
*/
if (fp->spinodes) {
sbp->sb_spino_align = sbp->sb_inoalignmt;
- sbp->sb_inoalignmt = \
- XFS_INODES_PER_CHUNK * \
+ sbp->sb_inoalignmt = XFS_INODES_PER_CHUNK *
sbp->sb_inodesize >> sbp->sb_blocklog;
sbp->sb_features_incompat |= XFS_SB_FEAT_INCOMPAT_SPINODES;
}
@@ -1090,7 +1089,7 @@ main(
.lazy_sb_counters = true,
.projid16bit = false,
.crcs_enabled = true,
- .dirftype = false,
+ .dirftype = true,
.parent_pointers = false,
};

@@ -1109,7 +1108,6 @@ main(
liflag = laflag = lsflag = lsuflag = lsunitflag = ldflag = lvflag = 0;
loginternal = 1;
logagno = logblocks = rtblocks = rtextblocks = 0;
- sb_feat.dirftype = 1; /* inode type information in the dir */
Nflag = nlflag = nsflag = nvflag = 0;
nftype = 0;
dirblocklog = dirblocksize = 0;