Re: [PATCH 00/19 v2] mkfs cleaning

Dave Chinner
2016-05-10T06:11:02Z

On Thu, Apr 21, 2016 at 11:39:34AM +0200, Jan Tulak wrote:
> Updated version. Most notable changes are dropping of
> "xfsprogs: disable truncating of files", reverting
> "don't treat files as though they are block devices"
> back to Dave's version, and adding a new patch
> "mkfs: conflicting values with disabled crc should fail."

Looking at xfstests runs, new failures are:

generic/054 -
generic/055 - both fail with:

+*** mkfs failed: -l version=2,su=4096 ***

and the .full file has this specific error:

Illegal value 4096 for -l su option. value is too small

indicating that we should be allowing (2^N * block size) log
stripe units to be set. This will be a limit configuration issue,
most likely needing fixing in mkfs.

xfs/096 6s ... - output mismatch (see /home/dave/src/xfstests-dev/results//xfs/xfs/096.out.bad)
--- tests/xfs/096.out 2016-04-05 11:11:36.814382107 +1000
+++ /home/dave/src/xfstests-dev/results//xfs/xfs/096.out.bad 2016-05-10 12:54:25.956199714 +1000
@@ -2,18 +2,62 @@

# su too big but must be a multiple of fs block size too
--- mkfs=-l version=2,su=262656 ---
-log stripe unit (262656) must be a multiple of the block size (4096)
+Illegal value 262656 for -l su option. value is too large
+Usage: mkfs.xfs
+/* blocksize */ [-b log=n|size=num]
...
(Run 'diff -u tests/xfs/096.out /home/dave/src/xfstests-dev/results//xfs/xfs/096.out.bad' to see the entire diff)

This test is explicitly testing an invalid value, checking that it
falls back to a sane default. This patchset has changed the
behaviour, so the xfstest will need some rework to handle both old
and new mkfs behaviour.

Can you send patches to fix all these up?

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com