From: Carlos Maiolino <cmaiolino@redhat.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_db: defang frag command
Date: Thu, 12 May 2016 11:23:23 +0200 [thread overview]
Message-ID: <20160512092323.GB28780@redhat.com> (raw)
In-Reply-To: <2d21b9ba-6db7-e239-3be8-a7bd5e1c39cc@sandeen.net>
On Wed, May 11, 2016 at 02:41:28PM -0500, Eric Sandeen wrote:
> Too many people freak out about this fictitious "fragmentation
> factor." As shown in the fact, it is largely meaningless, because
> the number approaches 100% extremely quickly for just a few
> extents per file.
>
> I thought about removing it altogether, but perhaps a note
> about its uselessness, and a more soothing metric (avg extents
> per file) might be useful.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/db/frag.c b/db/frag.c
> index 36bb689..e11b140 100644
> --- a/db/frag.c
> +++ b/db/frag.c
> @@ -172,6 +172,10 @@ frag_f(
> answer = 0.0;
> dbprintf(_("actual %llu, ideal %llu, fragmentation factor %.2f%%\n"),
> extcount_actual, extcount_ideal, answer);
> + dbprintf(_("Note, this number is largely meaningless.\n"));
> + answer = (double)extcount_actual / (double)extcount_ideal;
> + dbprintf(_("Files on this filesystem average %.2f extents per file\n"),
> + answer);
> return 0;
> }
I'm not quite comfortable with it, in my mind, if it's meaningless, why should
we print it?
I agree with printing the average though.
>
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-05-12 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 19:41 [PATCH] xfs_db: defang frag command Eric Sandeen
2016-05-12 9:23 ` Carlos Maiolino [this message]
2016-05-23 15:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512092323.GB28780@redhat.com \
--to=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox