From: Christoph Hellwig <hch@infradead.org>
To: Bill O'Donnell <billodo@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v5 1/2] libxcmd: generalize topology functions
Date: Thu, 12 May 2016 04:55:13 -0700 [thread overview]
Message-ID: <20160512115513.GD32528@infradead.org> (raw)
In-Reply-To: <1463006717-6104-2-git-send-email-billodo@redhat.com>
I still think libxfs would be the better place, but otherwise this looks
fine in general.
> +#ifdef ENABLE_BLKID
> +# include <blkid/blkid.h>
> +#endif /* ENABLE_BLKID */
> +#include "xfs_multidisk.h"
But what tree is this against? I can't find a xfs_multidisk.h in
the master branch, nor in this patch?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-05-12 11:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 22:45 [PATCH v5 0/2] xfs_repair: improved secondary sb search Bill O'Donnell
2016-05-11 22:45 ` [PATCH v5 1/2] libxcmd: generalize topology functions Bill O'Donnell
2016-05-12 11:55 ` Christoph Hellwig [this message]
2016-05-12 12:20 ` Bill O'Donnell
2016-05-12 14:47 ` Christoph Hellwig
2016-05-12 15:04 ` Eric Sandeen
2016-05-12 21:42 ` Dave Chinner
2016-05-30 2:13 ` Dave Chinner
2016-05-11 22:45 ` [PATCH v5 2/2] xfs_repair: new secondary superblock search method Bill O'Donnell
2016-05-12 1:09 ` [PATCH v5 0/2] xfs_repair: improved secondary sb search Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512115513.GD32528@infradead.org \
--to=hch@infradead.org \
--cc=billodo@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox