From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: make several functions static
Date: Mon, 23 May 2016 07:44:25 -0700 [thread overview]
Message-ID: <20160523144425.GA9319@infradead.org> (raw)
In-Reply-To: <3ec4e394-1885-6f3e-f909-c9a77a72668b@sandeen.net>
On Thu, May 19, 2016 at 02:16:25PM -0500, Eric Sandeen wrote:
> Al Viro noticed that xfs_lock_inodes should be static, and
> that led to ... a few more.
>
> These are just the easy ones, others require moving functions
> higher in source files, so that's not done here to keep
> this review simple.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
>
> We aren't using STATIC anymore ... right?
We're moving away from it at least, although not very stringently..
> FWIW cross-applying to xfsprogs picks up a handful of these
> as well, and it's still happy too.
Yeah - seems like none of them is of the odd static in kernel but not in
xfsprogs kind.
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-05-23 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 19:16 [PATCH] xfs: make several functions static Eric Sandeen
2016-05-23 14:44 ` Christoph Hellwig [this message]
2016-06-01 1:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523144425.GA9319@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox