From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_db: allow recalculating CRCs on invalid metadata
Date: Mon, 23 May 2016 07:52:50 -0700 [thread overview]
Message-ID: <20160523145250.GF9319@infradead.org> (raw)
In-Reply-To: <ee586739-e804-8174-8497-cc8a992b9752@sandeen.net>
On Thu, May 12, 2016 at 06:03:15PM -0500, Eric Sandeen wrote:
> Using "TYP_NO_CRC_OFF" seems a little weird from a naming perspective;
> it's not really a TYP_* is it? Its opposite is things like
> XFS_AGI_CRC_OFF; NO_FIXED_CRC_OFF might be better to not confuse it
> with the TYP_ on-disk types? Just a thought.
Agreed. How about adding a _F inbetween, e.g. TYP_F_NO_CRC_OFF?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-05-23 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 22:35 [PATCH] xfs_db: allow recalculating CRCs on invalid metadata Dave Chinner
2016-05-12 23:03 ` Eric Sandeen
2016-05-12 23:28 ` Dave Chinner
2016-05-12 23:31 ` Eric Sandeen
2016-05-23 14:52 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523145250.GF9319@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox