From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 736DB7CA4 for ; Mon, 23 May 2016 09:52:52 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 43DF78F8040 for ; Mon, 23 May 2016 07:52:52 -0700 (PDT) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id ZSABlnZ8UmetJB02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Mon, 23 May 2016 07:52:51 -0700 (PDT) Date: Mon, 23 May 2016 07:52:50 -0700 From: Christoph Hellwig Subject: Re: [PATCH] xfs_db: allow recalculating CRCs on invalid metadata Message-ID: <20160523145250.GF9319@infradead.org> References: <1463092513-5462-1-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs@oss.sgi.com On Thu, May 12, 2016 at 06:03:15PM -0500, Eric Sandeen wrote: > Using "TYP_NO_CRC_OFF" seems a little weird from a naming perspective; > it's not really a TYP_* is it? Its opposite is things like > XFS_AGI_CRC_OFF; NO_FIXED_CRC_OFF might be better to not confuse it > with the TYP_ on-disk types? Just a thought. Agreed. How about adding a _F inbetween, e.g. TYP_F_NO_CRC_OFF? _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs