Re: [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok()

Jan Kara
2016-08-09T09:32:57Z

On Tue 09-08-16 01:27:56, Christoph Hellwig wrote:
> > +static int
> > +xfs_vn_change_ok(
> > + struct dentry *dentry,
> > + struct iattr *iattr)
>
> Please don't use the _vn prefix for something that's not an
> actual inode operation (and we should do a mess rename to
> _iop one day as well.)
>
> > +int
> > +xfs_vn_setattr_nonsize(
> > + struct dentry *dentry,
> > + struct iattr *iattr)
>
> Same here.

So do you suggest xfs_iop_change_ok and xfs_iop_setattr_nonsize? I don't
really care, I just remember Dave had some ideas how names should be
consistent and this naming was his idea...

Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR