Re: [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok()

Christoph Hellwig
2016-08-09T08:28:00Z

> +static int
> +xfs_vn_change_ok(
> + struct dentry *dentry,
> + struct iattr *iattr)

Please don't use the _vn prefix for something that's not an
actual inode operation (and we should do a mess rename to
_iop one day as well.)

> +int
> +xfs_vn_setattr_nonsize(
> + struct dentry *dentry,
> + struct iattr *iattr)

Same here.