From: Dave Chinner <david@fromorbit.com>
To: Bill O'Donnell <billodo@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v5 1/2] libxcmd: generalize topology functions
Date: Mon, 30 May 2016 12:13:30 +1000 [thread overview]
Message-ID: <20160530021330.GL26977@dastard> (raw)
In-Reply-To: <1463006717-6104-2-git-send-email-billodo@redhat.com>
On Wed, May 11, 2016 at 05:45:16PM -0500, Bill O'Donnell wrote:
> Move general topology functions from xfs_mkfs to new topology
> collection in libxcmd.
>
> Signed-off-by: Bill O'Donnell <billodo@redhat.com>
FYI, this patch breaks 'make deb'.
I don't expect anyone to know this - the debian/rules build script
has a special hand-rolled mkfs build for the debian installer. This
new libxcmd dependency also needs to be described in that script.
I've fixed that up, but it's also pointed out a couple of other
things to do with dependencies:
> diff --git a/mkfs/Makefile b/mkfs/Makefile
> index 63ba4ec..f0e4ce1 100644
> --- a/mkfs/Makefile
> +++ b/mkfs/Makefile
> @@ -10,7 +10,7 @@ LTCOMMAND = mkfs.xfs
> HFILES =
> CFILES = maxtrres.c proto.c xfs_mkfs.c
>
> -LLDLIBS += $(LIBBLKID) $(LIBXFS) $(LIBUUID) $(LIBRT) $(LIBPTHREAD)
> +LLDLIBS += $(LIBBLKID) $(LIBXFS) $(LIBUUID) $(LIBRT) $(LIBPTHREAD) $(LIBXCMD)
> LTDEPENDENCIES += $(LIBXFS)
> LLDFLAGS = -static-libtool-libs
mkfs.xfs also needs the build dependency on libxcmd to be expressed
in LTDEPENDENCIES. It's just lucky that other targets have already
expressed such "libxfs + libxcmd" dependencies as that ensured
libxcmd was already built before mkfs tries to link against it.
Blind luck strikes again!
Those top level build dependencies are expressed in the top level
Makefile like so:
--- a/Makefile
+++ b/Makefile
@@ -82,6 +82,7 @@ io: libxcmd libhandle
quota: libxcmd
repair: libxlog
copy: libxlog
+mkfs: libxcmd
ifeq ($(HAVE_BUILDDEFS), yes)
include $(BUILDRULES)
I've fixed these problems because I need to build .deb packages to
deploy changes for testing.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-05-30 2:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 22:45 [PATCH v5 0/2] xfs_repair: improved secondary sb search Bill O'Donnell
2016-05-11 22:45 ` [PATCH v5 1/2] libxcmd: generalize topology functions Bill O'Donnell
2016-05-12 11:55 ` Christoph Hellwig
2016-05-12 12:20 ` Bill O'Donnell
2016-05-12 14:47 ` Christoph Hellwig
2016-05-12 15:04 ` Eric Sandeen
2016-05-12 21:42 ` Dave Chinner
2016-05-30 2:13 ` Dave Chinner [this message]
2016-05-11 22:45 ` [PATCH v5 2/2] xfs_repair: new secondary superblock search method Bill O'Donnell
2016-05-12 1:09 ` [PATCH v5 0/2] xfs_repair: improved secondary sb search Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530021330.GL26977@dastard \
--to=david@fromorbit.com \
--cc=billodo@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox