From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix broken multi-fsb buffer logging
Date: Wed, 1 Jun 2016 08:39:56 +1000 [thread overview]
Message-ID: <20160531223956.GF12670@dastard> (raw)
In-Reply-To: <20160531083252.GR26977@dastard>
On Tue, May 31, 2016 at 06:32:52PM +1000, Dave Chinner wrote:
> On Wed, May 25, 2016 at 03:31:07PM -0400, Brian Foster wrote:
> > Multi-block buffers are logged based on buffer offset in
> > xfs_trans_log_buf(). xfs_buf_item_log() ultimately walks each mapping in
> > the buffer and marks the associated range to be logged in the
> > xfs_buf_log_format bitmap for that mapping. This code is broken,
> > however, [....]
>
> [snip description I've not read, and go look at the code changes]
....
> So from the code perspective the change looks correct. I've looked
> over all the other users of bp->b_maps[i].bm_len and loops over
> bli_format_count and I can't see any other obvious problems. I'm
> going to leave this under test overnight and see if anything pops
> up...
Passes all the tests I've thrown at it. multiple xfstests runs on
multiple machines with dir block sizes from 16k to 64k, fsmark runs
with 16k and 64k block sizes, dbench stress loops with up to 500
processes running at once, etc.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
I'll commit this when I get to updating the xfs trees now that
the merge window has closed and 4.7-rc1 is out. Hopefully that will
be later today....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-05-31 22:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 19:31 [PATCH] xfs: fix broken multi-fsb buffer logging Brian Foster
2016-05-30 14:08 ` Brian Foster
2016-05-30 22:08 ` Eric Sandeen
2016-05-31 8:32 ` Dave Chinner
2016-05-31 22:39 ` Dave Chinner [this message]
2016-05-31 18:29 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531223956.GF12670@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox