From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: make several functions static
Date: Wed, 1 Jun 2016 11:42:14 +1000 [thread overview]
Message-ID: <20160601014214.GH12670@dastard> (raw)
In-Reply-To: <3ec4e394-1885-6f3e-f909-c9a77a72668b@sandeen.net>
On Thu, May 19, 2016 at 02:16:25PM -0500, Eric Sandeen wrote:
> Al Viro noticed that xfs_lock_inodes should be static, and
> that led to ... a few more.
>
> These are just the easy ones, others require moving functions
> higher in source files, so that's not done here to keep
> this review simple.
....
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index c5d4eba..04afe38 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -524,7 +524,7 @@ xfs_setattr_mode(
> inode->i_mode |= mode & ~S_IFMT;
> }
>
> -void
> +static void
> xfs_setattr_time(
> struct xfs_inode *ip,
> struct iattr *iattr)
> diff --git a/fs/xfs/xfs_iops.h b/fs/xfs/xfs_iops.h
> index a0f84ab..d4bcc29 100644
> --- a/fs/xfs/xfs_iops.h
> +++ b/fs/xfs/xfs_iops.h
> @@ -30,7 +30,6 @@ extern ssize_t xfs_vn_listxattr(struct dentry *, char *data, size_t size);
> */
> #define XFS_ATTR_NOACL 0x01 /* Don't call posix_acl_chmod */
>
> -extern void xfs_setattr_time(struct xfs_inode *ip, struct iattr *iattr);
> extern int xfs_setattr_nonsize(struct xfs_inode *ip, struct iattr *vap,
> int flags);
> extern int xfs_setattr_size(struct xfs_inode *ip, struct iattr *vap);
Just a note: xfs_pnfs.c uses this function, so it can't be made
static. I've dropped this hunk. Maybe add CONFIG_NFSD_PNFS=y to you
kernel config?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-06-01 1:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 19:16 [PATCH] xfs: make several functions static Eric Sandeen
2016-05-23 14:44 ` Christoph Hellwig
2016-06-01 1:42 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601014214.GH12670@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox