From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfs: add an option to enable reflinks at mount time
Date: Mon, 6 Jun 2016 09:52:36 -0700 [thread overview]
Message-ID: <20160606165236.GB5737@birch.djwong.org> (raw)
In-Reply-To: <20160606112950.GC23695@redhat.com>
On Mon, Jun 06, 2016 at 01:29:50PM +0200, Carlos Maiolino wrote:
> Ugh, I just realized dave and derrick had already replied, pointing issues I
> didn't figure out, but still I'm curious for the question I asked :)
>
> > Hi hch,
> >
> > The patchset looks good, although I'm not quite familiar with the reflink code
> > so, I apologize if it is a stupid question
> >
> > After enabling the reflink feature during mount time, I believe this will not
> > have any problems in future mounts of this filesystem without reflink support?
> >
> > > index 84348af..dfa5077 100644
> > > --- a/fs/xfs/xfs_super.c
> > > +++ b/fs/xfs/xfs_super.c
> > > @@ -82,7 +82,7 @@ enum {
> > > Opt_quota, Opt_noquota, Opt_usrquota, Opt_grpquota, Opt_prjquota,
> > > Opt_uquota, Opt_gquota, Opt_pquota,
> > > Opt_uqnoenforce, Opt_gqnoenforce, Opt_pqnoenforce, Opt_qnoenforce,
> > > - Opt_discard, Opt_nodiscard, Opt_dax, Opt_err,
> > > + Opt_discard, Opt_nodiscard, Opt_reflink, Opt_dax, Opt_err,
> > > };
> > >
> > > static const match_table_t tokens = {
> > > @@ -132,6 +132,7 @@ static const match_table_t tokens = {
> > > {Opt_qnoenforce, "qnoenforce"}, /* same as uqnoenforce */
> > > {Opt_discard, "discard"}, /* Discard unused blocks */
> > > {Opt_nodiscard, "nodiscard"}, /* Do not discard unused blocks */
> > > + {Opt_reflink, "reflink"}, /* Do not discard unused blocks */
> > ^^^^
I hadn't noticed the incorrect comment; it's good of you to point it out. :)
--D
> >
> > Also, I believe this comment is wrong!?
> >
> > Cheers
> >
> > --
> > Carlos
> >
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
>
> --
> Carlos
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-06-06 16:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 14:19 [RFC] allow enabling reflinks at runtime Christoph Hellwig
2016-06-02 14:19 ` [PATCH 1/3] xfs: add xfs_mp_hasreflink Christoph Hellwig
2016-06-02 14:19 ` [PATCH 2/3] xfs: refactor xfs_refcountbt_alloc_block Christoph Hellwig
2016-06-02 14:19 ` [PATCH 3/3] xfs: add an option to enable reflinks at mount time Christoph Hellwig
2016-06-06 11:23 ` Carlos Maiolino
2016-06-06 11:29 ` Carlos Maiolino
2016-06-06 16:52 ` Darrick J. Wong [this message]
2016-06-08 7:04 ` Christoph Hellwig
2016-06-08 8:07 ` Carlos Maiolino
2016-06-08 8:10 ` Carlos Maiolino
2016-06-09 22:57 ` Dave Chinner
2016-06-02 22:54 ` [RFC] allow enabling reflinks at runtime Dave Chinner
2016-06-03 1:58 ` Darrick J. Wong
2016-06-06 18:52 ` Darrick J. Wong
2016-06-08 7:10 ` Christoph Hellwig
2016-06-08 7:11 ` Christoph Hellwig
2016-06-09 17:45 ` Darrick J. Wong
2016-06-09 23:33 ` Dave Chinner
2016-07-13 5:36 ` Darrick J. Wong
2016-10-26 20:49 ` Darrick J. Wong
2016-11-03 16:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606165236.GB5737@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).