From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 08C617CA0 for ; Fri, 10 Jun 2016 07:19:39 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id A084A304048 for ; Fri, 10 Jun 2016 05:19:38 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id nvRHTXCwGouYsD0k (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 10 Jun 2016 05:19:37 -0700 (PDT) Date: Fri, 10 Jun 2016 08:19:36 -0400 From: Brian Foster Subject: Re: [PATCH 0/4] xfs: online relabeling [RFC] Message-ID: <20160610121936.GC21568@bfoster.bfoster> References: <2305b486-f336-6d1e-9420-b69dc5bdc572@sandeen.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2305b486-f336-6d1e-9420-b69dc5bdc572@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs@oss.sgi.com On Thu, Jun 09, 2016 at 11:51:12AM -0500, Eric Sandeen wrote: > > > On 6/9/16 11:36 AM, Eric Sandeen wrote: > > Ok, this more or less works; not really up to snuff > > for submission or merging, just sketching it out, but some > > questions first: > > > > 1) Is there really any point to this? :) We did have one > > request, and btrfs can do it ... > > Seems reasonable to me. Any details on the use case for the request? > > 2) Is using m_growlock horrible? growfs is the only other > > thing that writes all supers, so I grabbed it. We don't > > want multiple relabels stepping on each other. > > > > 3) Is there some way to actually force the primary to disk? > > Right now the label change isn't actually visible on the > > primary until unmount, which defeats the purpose. I'm not > > sure if there's a straightforward/safe way to make it > > visible... > > Oh, sorry - I guess it is getting written out, but it's only > available via an O_DIRECT read from userspace; it's not > invalidating the cache. > > # io/xfs_io -c "label derp" /mnt/test > label = "derp" > > # dd if=/dev/sdb2 bs=512 count=1 | hexdump -C > ... > 00000060 00 00 0a 00 b4 e5 02 00 02 00 00 08 66 6f 6f 00 |............foo.| > ... > > # dd if=/dev/sdb2 iflag=direct bs=512 count=1 | hexdump -C > ... > 00000060 00 00 0a 00 b4 e5 02 00 02 00 00 08 64 65 72 70 |............derp| > ... > > # dd if=/dev/sdb2 bs=512 count=1 | hexdump -C > ... > 00000060 00 00 0a 00 b4 e5 02 00 02 00 00 08 66 6f 6f 00 |............foo.| > ... > > Guess I need to think about this some more. > Isn't this to be expected? You're directly accessing the block device of a mounted filesystem. I would think this is expected behavior, so long as the set/get interfaces through the fs are consistent. Brian > -Eric > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs