From: Willy Tarreau <w@1wt.eu>
To: Dave Chinner <david@fromorbit.com>
Cc: Greg KH <greg@kroah.com>,
xfs@oss.sgi.com, spender@grsecurity.net, stable@vger.kernel.org,
"Thomas D." <whissi@whissi.de>
Subject: Re: Something badly broken with the latest XFS changeset in all stable kernels?
Date: Wed, 15 Jun 2016 09:14:38 +0200 [thread overview]
Message-ID: <20160615071438.GA5294@1wt.eu> (raw)
In-Reply-To: <20160615065121.GE26977@dastard>
On Wed, Jun 15, 2016 at 04:51:21PM +1000, Dave Chinner wrote:
> > Overall the regression lived only 8 days in a single branch, I
> > guess it shows that our process works rather well and limits the exposure
> > to regressions.
>
> That it got as far as release and it took so long to get to the
> upstream maintainers shows the process could do with being improved.
Yep but users relying on oldest LTS usually run on servers that cannot
reboot without prior planning, so in practice we know that users tend
to be late by 1 week or more and often one or two versions. I'm pretty
sure this is the reason why a single user reported the issue. I'm not
saying this to dismiss the importance of a regression, just the fact
that the zero-risk never exists and that if an issue can only be
discovered in field (since the commit was backported according to the
tags and that the need to adapt it was not detected during the review
process), it will need one first victim to save all other users. In the
end the quick enough report ensured that most 3.14 users will not have
the time to upgrade to the broken version and 3.10/3.12 users will not
even have the opportunity to see the issue at all. That's what I'm
saying is not that bad.
We could imagine some automated tests depending on the affected files
and/or subsystems but it's not even certain that an automated test
would have detected this one :-/ We need to thank the initial reporter
here, and to encourage Brad to pass the information back ASAP next time
this happens via his channel.
Willy
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-06-15 7:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 21:57 Something badly broken with the latest XFS changeset in all stable kernels? Thomas D.
2016-06-15 0:02 ` Dave Chinner
2016-06-15 1:30 ` Greg KH
2016-06-15 5:28 ` Willy Tarreau
2016-06-15 6:51 ` Dave Chinner
2016-06-15 7:14 ` Willy Tarreau [this message]
2016-06-15 7:00 ` Jiri Slaby
2016-06-15 6:40 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615071438.GA5294@1wt.eu \
--to=w@1wt.eu \
--cc=david@fromorbit.com \
--cc=greg@kroah.com \
--cc=spender@grsecurity.net \
--cc=stable@vger.kernel.org \
--cc=whissi@whissi.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox