From: Dave Chinner <david@fromorbit.com>
To: Felix Janda <felix.janda@posteo.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/4] Remove off64_t from linux.h
Date: Mon, 20 Jun 2016 12:04:14 +1000 [thread overview]
Message-ID: <20160620020414.GH26977@dastard> (raw)
In-Reply-To: <20160618145238.GA17768@nyan>
On Sat, Jun 18, 2016 at 04:52:38PM +0200, Felix Janda wrote:
> The off64_t type is usually only conditionally exposed under the
> feature test macro _LARGEFILE64_SOURCE (also defined by _GNU_SOURCE).
> To make the public xfs headers more standalone therefore off64_t should
> be avoided.
"more standalone"?
What does that mean? And what does it mean for all the xfsprogs code
that still uses off64_t?
i.e. if you are going to make xfsprogs fail to compile on configs
that don't define off64_t, then it makes no sense to leave all the
users of off64_t in the xfsprogs code....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-06-20 2:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 14:52 [PATCH 1/4] Remove off64_t from linux.h Felix Janda
2016-06-20 2:04 ` Dave Chinner [this message]
2016-06-20 6:53 ` Felix Janda
2016-06-20 23:18 ` Dave Chinner
2016-06-21 20:07 ` Felix Janda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620020414.GH26977@dastard \
--to=david@fromorbit.com \
--cc=felix.janda@posteo.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox