* [PATCH] xfs_copy: fix minor sparse endian nit
@ 2016-06-17 16:44 Eric Sandeen
2016-06-20 10:41 ` Carlos Maiolino
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2016-06-17 16:44 UTC (permalink / raw)
To: xfs-oss
The intermediate variable should not have been endian-annotated;
it is the local cpu representation not the on-disk representation.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/copy/xfs_copy.c b/copy/xfs_copy.c
index 2119a0b..1bc5163 100644
--- a/copy/xfs_copy.c
+++ b/copy/xfs_copy.c
@@ -506,7 +506,7 @@ sb_update_uuid(
*/
if (!uuid_equal(&tcarg->uuid, &ag_hdr->xfs_sb->sb_uuid) &&
xfs_sb_version_hascrc(sb) && !xfs_sb_version_hasmetauuid(sb)) {
- __be32 feat;
+ __uint32_t feat;
feat = be32_to_cpu(ag_hdr->xfs_sb->sb_features_incompat);
feat |= XFS_SB_FEAT_INCOMPAT_META_UUID;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs_copy: fix minor sparse endian nit
2016-06-17 16:44 [PATCH] xfs_copy: fix minor sparse endian nit Eric Sandeen
@ 2016-06-20 10:41 ` Carlos Maiolino
0 siblings, 0 replies; 2+ messages in thread
From: Carlos Maiolino @ 2016-06-20 10:41 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Fri, Jun 17, 2016 at 11:44:44AM -0500, Eric Sandeen wrote:
> The intermediate variable should not have been endian-annotated;
> it is the local cpu representation not the on-disk representation.
>
Looks good, you can add:
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/copy/xfs_copy.c b/copy/xfs_copy.c
> index 2119a0b..1bc5163 100644
> --- a/copy/xfs_copy.c
> +++ b/copy/xfs_copy.c
> @@ -506,7 +506,7 @@ sb_update_uuid(
> */
> if (!uuid_equal(&tcarg->uuid, &ag_hdr->xfs_sb->sb_uuid) &&
> xfs_sb_version_hascrc(sb) && !xfs_sb_version_hasmetauuid(sb)) {
> - __be32 feat;
> + __uint32_t feat;
>
> feat = be32_to_cpu(ag_hdr->xfs_sb->sb_features_incompat);
> feat |= XFS_SB_FEAT_INCOMPAT_META_UUID;
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-20 10:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-17 16:44 [PATCH] xfs_copy: fix minor sparse endian nit Eric Sandeen
2016-06-20 10:41 ` Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox