[PATCH] xfs_copy: fix minor sparse endian nit

[PATCH] xfs_copy: fix minor sparse endian nit

[Eric Sandeen]

The intermediate variable should not have been endian-annotated;
it is the local cpu representation not the on-disk representation.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/copy/xfs_copy.c b/copy/xfs_copy.c
index 2119a0b..1bc5163 100644
--- a/copy/xfs_copy.c
+++ b/copy/xfs_copy.c
@@ -506,7 +506,7 @@ sb_update_uuid(
 	 */
 	if (!uuid_equal(&tcarg->uuid, &ag_hdr->xfs_sb->sb_uuid) &&
 	    xfs_sb_version_hascrc(sb) && !xfs_sb_version_hasmetauuid(sb)) {
-		__be32 feat;
+		__uint32_t feat;
 
 		feat = be32_to_cpu(ag_hdr->xfs_sb->sb_features_incompat);
 		feat |= XFS_SB_FEAT_INCOMPAT_META_UUID;

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_copy: fix minor sparse endian nit

[Carlos Maiolino]

On Fri, Jun 17, 2016 at 11:44:44AM -0500, Eric Sandeen wrote:
> The intermediate variable should not have been endian-annotated;
> it is the local cpu representation not the on-disk representation.
> 

Looks good, you can add:

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> diff --git a/copy/xfs_copy.c b/copy/xfs_copy.c
> index 2119a0b..1bc5163 100644
> --- a/copy/xfs_copy.c
> +++ b/copy/xfs_copy.c
> @@ -506,7 +506,7 @@ sb_update_uuid(
>  	 */
>  	if (!uuid_equal(&tcarg->uuid, &ag_hdr->xfs_sb->sb_uuid) &&
>  	    xfs_sb_version_hascrc(sb) && !xfs_sb_version_hasmetauuid(sb)) {
> -		__be32 feat;
> +		__uint32_t feat;
>  
>  		feat = be32_to_cpu(ag_hdr->xfs_sb->sb_features_incompat);
>  		feat |= XFS_SB_FEAT_INCOMPAT_META_UUID;
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Carlos

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs