Re: [PATCH v2] xfs: indentation fix in xfs_btree_get_iroot()

Kaho Ng
2016-06-22T10:31:02Z

Thanks for the suggestion. I am going to tidy up the things and resend it.

2016-06-22 16:23 GMT+08:00 Carlos Maiolino <cmaiolino@redhat.com>:
> On Wed, Jun 22, 2016 at 04:39:43PM +1000, Dave Chinner wrote:
>> On Wed, Jun 22, 2016 at 12:11:37PM +0800, Kaho Ng wrote:
>> > The indentation in this function is different from the other functions.
>> > Those spacebars are converted to tabs to improve readability.
>> >
>> > Signed-off-by: Kaho Ng <ngkaho1234@gmail.com>
>> > ---
>> > fs/xfs/libxfs/xfs_btree.c | 8 ++++----
>> > 1 file changed, 4 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
>> > index 1f88e1c..4f84dde 100644
>> > --- a/fs/xfs/libxfs/xfs_btree.c
>> > +++ b/fs/xfs/libxfs/xfs_btree.c
>> > @@ -543,12 +543,12 @@ xfs_btree_ptr_addr(
>> > */
>> > STATIC struct xfs_btree_block *
>> > xfs_btree_get_iroot(
>> > - struct xfs_btree_cur *cur)
>> > + struct xfs_btree_cur *cur)
>> > {
>> > - struct xfs_ifork *ifp;
>> > + struct xfs_ifork *ifp;
>> >
>> > - ifp = XFS_IFORK_PTR(cur->bc_private.b.ip, cur-
>> > >bc_private.b.whichfork);
>> > - return (struct xfs_btree_block *)ifp->if_broot;
>> > + ifp = XFS_IFORK_PTR(cur->bc_private.b.ip, cur-
>> > >bc_private.b.whichfork);
>> > + return (struct xfs_btree_block *)ifp->if_broot;
>> > }
>>
>> That's better, but your mailer is still doing weird things to the
>> patch. It line wrapped it this time, and converted all the spaces to
>> some wierd multi-byte character instead of a plain ascii space.
>>
>> What you should do is send the patch to yourself, extract it from
>> the email you receive, and try to apply it to a clean tree. If you
>> can do that, then the patch is not getting mangled when you send it.
>> See Documentation/SubmittingPatches and
>> Documentation/email-clients.txt for help.
>>
>
> This is a problem when sending patches from a gmail account. It's converted to a
> base64 format, instead of pure clean text.
>
> I'd setup git to send the patch through the gmail smtp using git send-email. So
> it won't screw up with the file format. Well, at least, that's what I do when I
> need to send patches through a gmail account :)
>
> --
> Carlos