From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 5B3777CA1 for ; Wed, 22 Jun 2016 03:23:42 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 2D122304032 for ; Wed, 22 Jun 2016 01:23:39 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id GOiclbrQccDHQ0eb (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 22 Jun 2016 01:23:38 -0700 (PDT) Date: Wed, 22 Jun 2016 10:23:32 +0200 From: Carlos Maiolino Subject: Re: [PATCH v2] xfs: indentation fix in xfs_btree_get_iroot() Message-ID: <20160622082332.GH28212@redhat.com> References: <1466568697.14061.1.camel@gmail.com> <20160622063943.GU12670@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160622063943.GU12670@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Kaho Ng , "xfs@oss.sgi.com" On Wed, Jun 22, 2016 at 04:39:43PM +1000, Dave Chinner wrote: > On Wed, Jun 22, 2016 at 12:11:37PM +0800, Kaho Ng wrote: > > The indentation in this function is different from the other functions. > > Those spacebars are converted to tabs to improve readability. > > = > > Signed-off-by: Kaho Ng > > --- > > =A0fs/xfs/libxfs/xfs_btree.c | 8 ++++---- > > =A01 file changed, 4 insertions(+), 4 deletions(-) > > = > > diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c > > index 1f88e1c..4f84dde 100644 > > --- a/fs/xfs/libxfs/xfs_btree.c > > +++ b/fs/xfs/libxfs/xfs_btree.c > > @@ -543,12 +543,12 @@ xfs_btree_ptr_addr( > > =A0 */ > > =A0STATIC struct xfs_btree_block * > > =A0xfs_btree_get_iroot( > > -=A0=A0=A0=A0=A0=A0=A0struct xfs_btree_cur=A0=A0=A0=A0*cur) > > + struct xfs_btree_cur *cur) > > =A0{ > > -=A0=A0=A0=A0=A0=A0=A0struct xfs_ifork=A0=A0=A0=A0=A0=A0=A0=A0*ifp; > > + struct xfs_ifork *ifp; > > =A0 > > -=A0=A0=A0=A0=A0=A0=A0ifp =3D XFS_IFORK_PTR(cur->bc_private.b.ip, cur- > > >bc_private.b.whichfork); > > -=A0=A0=A0=A0=A0=A0=A0return (struct xfs_btree_block *)ifp->if_broot; > > + ifp =3D XFS_IFORK_PTR(cur->bc_private.b.ip, cur- > > >bc_private.b.whichfork); > > + return (struct xfs_btree_block *)ifp->if_broot; > > =A0} > = > That's better, but your mailer is still doing weird things to the > patch. It line wrapped it this time, and converted all the spaces to > some wierd multi-byte character instead of a plain ascii space. > = > What you should do is send the patch to yourself, extract it from > the email you receive, and try to apply it to a clean tree. If you > can do that, then the patch is not getting mangled when you send it. > See Documentation/SubmittingPatches and > Documentation/email-clients.txt for help. > = This is a problem when sending patches from a gmail account. It's converted= to a base64 format, instead of pure clean text. I'd setup git to send the patch through the gmail smtp using git send-email= . So it won't screw up with the file format. Well, at least, that's what I do wh= en I need to send patches through a gmail account :) -- = Carlos _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs