Re: [PATCH 008/119] xfs: separate freelist fixing into a separate helper

Dave Chinner
2016-06-21T00:48:34Z

On Fri, Jun 17, 2016 at 04:52:04AM -0700, Christoph Hellwig wrote:
> > +/* Ensure that the freelist is at full capacity. */
> > +int
> > +xfs_free_extent_fix_freelist(
> > + struct xfs_trans *tp,
> > + xfs_agnumber_t agno,
> > + struct xfs_buf **agbp)
> > {
> > - xfs_alloc_arg_t args;
> > - int error;
> > + xfs_alloc_arg_t args;
>
> Use struct xfs_alloc_arg if you change this anyway.
>
> > + int error;
> >
> > - ASSERT(len != 0);
> > memset(&args, 0, sizeof(xfs_alloc_arg_t));
>
> Same here.
>
> > - if (args.agbno + len >
> > - be32_to_cpu(XFS_BUF_TO_AGF(args.agbp)->agf_length)) {
> > - error = -EFSCORRUPTED;
> > - goto error0;
> > - }
> > + XFS_WANT_CORRUPTED_GOTO(mp,
> > + agbno + len <= be32_to_cpu(XFS_BUF_TO_AGF(agbp)->agf_length),
> > + err);
>
> This introduces an overly long line.
>
> But except for these nitpicks this looks fine:

I'll clean them up on commit.

-Dave.

--
Dave Chinner
david@fromorbit.com