From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 126D27CA0 for ; Thu, 23 Jun 2016 20:50:26 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id D86798F8033 for ; Thu, 23 Jun 2016 18:50:22 -0700 (PDT) Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id rIKKADGAEi01XPYH for ; Thu, 23 Jun 2016 18:50:20 -0700 (PDT) Date: Fri, 24 Jun 2016 11:50:18 +1000 From: Dave Chinner Subject: Re: [PATCH 008/145] libxfs: add more list operations Message-ID: <20160624015018.GC12670@dastard> References: <146612704434.16048.12932915166928562654.stgit@birch.djwong.org> <146612709549.16048.6522744362673808871.stgit@birch.djwong.org> <20160624004022.GB12670@dastard> <20160624004638.GA18415@birch.djwong.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160624004638.GA18415@birch.djwong.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: "Darrick J. Wong" Cc: xfs@oss.sgi.com On Thu, Jun 23, 2016 at 05:46:38PM -0700, Darrick J. Wong wrote: > On Fri, Jun 24, 2016 at 10:40:22AM +1000, Dave Chinner wrote: > > On Thu, Jun 16, 2016 at 06:31:35PM -0700, Darrick J. Wong wrote: > > > Add some list operations that the deferred rmap code requires. > > > > > > Signed-off-by: Darrick J. Wong > > > > This has all come from the linux kernel, right? > > Yes. > > > Can you tell me > > which files it has come from so I can add it to the commit message? > > lib/list_sort.c for all the list_sort stuff, > include/linux/list.h for the rest of the list_* stuff, > include/linux/kernel.h for container_of. I thought we already had container_of. Ah, only inside __KERNEL__ code fragments.... > > Maybe it would be better to keep the list sorting code in it's own > > file (e.g. libxfs/list_sort.c) just to keep a bit of separation > > between the xfs code and code that is copied in from outside? > > I'd wondered if it made more sense to do that, but (sort of arbitrarily > decided not to add more files). keeping it in a spearate file makes it easier to update in future (e.g. forklift replacement of radix tree code). maybe we don't need to do this here, but I don't mind adding new files for stuff like this... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs