From: Dave Chinner <david@fromorbit.com>
To: Hou Tao <houtao1@huawei.com>
Cc: miaoxie@huawei.com, fangwei1@huawei.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: simplify the calculation of tpp at xfs_bmdr_to_bmbt
Date: Fri, 24 Jun 2016 16:38:05 +1000 [thread overview]
Message-ID: <20160624063805.GD12670@dastard> (raw)
In-Reply-To: <1466746760-155962-1-git-send-email-houtao1@huawei.com>
On Fri, Jun 24, 2016 at 01:39:20PM +0800, Hou Tao wrote:
> remove the usage of rblocklen at xfs_bmdr_to_bmbt, and
> use be16_to_cpu(dblock->bb_numrecs) instead. It also
> reduces an extra calculation.
What problem does this fix, why does it need to be made and
how did you test it?
We have to be really careful about changing code that interacts with
the on-disk format, as any bugs we introduced will result in
filesystem corruption. Hence you need to explain to the reviewers
why the change needs to be made to the reviewers...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-06-24 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 5:39 [PATCH] xfs: simplify the calculation of tpp at xfs_bmdr_to_bmbt Hou Tao
2016-06-24 6:38 ` Dave Chinner [this message]
2016-06-24 7:01 ` Hou Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624063805.GD12670@dastard \
--to=david@fromorbit.com \
--cc=fangwei1@huawei.com \
--cc=houtao1@huawei.com \
--cc=miaoxie@huawei.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox