From: Dave Chinner <david@fromorbit.com>
To: Damien Gombault <damien.gombault@recia.fr>
Cc: xfs@oss.sgi.com
Subject: Re: Bug (?) : cumulative xfsrestore does not restore files and folders in a directory which was renamed
Date: Sat, 25 Jun 2016 09:03:46 +1000 [thread overview]
Message-ID: <20160624230346.GH12670@dastard> (raw)
In-Reply-To: <eacabe85-cdff-7fbc-8bb6-c8eb51fc0dac@recia.fr>
On Fri, Jun 24, 2016 at 03:51:57PM +0200, Damien Gombault wrote:
> Hi.
>
> Thank you for the patch.
>
> The patch fixes simple cases (like my reproducer) but it does not fix
> restoration of more complex directory structures : I have tested the
> patch on my
> real data, it fixes some but not all warnings (a user renamed/moved
> a lots of
> files and directory between the 2 dumps).
>
> Here is another testcase which fails (with the patch) :
>
> mkdir dira
> mkdir dira/dirc
> touch dira/dirc/filea
> mkdir dirb
>
> .
> ├── dira
> │ └── dirc
> │ └── filea
> └── dirb
>
> Make a level 0 dump.
>
> mv dirb dira/dirB
> mv dira/dirc/ dira/dirB/dirC
> touch dira/dirB/dirC/fileb
>
> .
> └── dira
> └── dirB
> └── dirC
> ├── filea
> └── fileb
Well, yes. I specifically said in the patch description that it
doesn't fix those nested dependency cases and that much deeper
surgery is needed to handle those cases.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-06-24 23:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 14:45 Bug (?) : cumulative xfsrestore does not restore files and folders in a directory which was renamed Damien Gombault
2016-06-22 22:09 ` Dave Chinner
2016-06-22 22:23 ` Dave Chinner
2016-06-23 1:42 ` Dave Chinner
2016-06-23 14:17 ` Bill O'Donnell
2016-06-24 13:51 ` Damien Gombault
2016-06-24 23:03 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624230346.GH12670@dastard \
--to=david@fromorbit.com \
--cc=damien.gombault@recia.fr \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox