From: Eryu Guan <eguan@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 16/20] reflink: test cross-mountpoint reflink and dedupe
Date: Mon, 4 Jul 2016 14:51:37 +0800 [thread overview]
Message-ID: <20160704065137.GW23649@eguan.usersys.redhat.com> (raw)
In-Reply-To: <146612806287.25024.6626531953151914169.stgit@birch.djwong.org>
On Thu, Jun 16, 2016 at 06:47:42PM -0700, Darrick J. Wong wrote:
> Test sharing blocks via reflink and dedupe between two different
> mountpoints of the same filesystem. This shouldn't work, since
> we don't allow cross-mountpoint functions.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> common/reflink | 2 +
> tests/generic/927 | 88 +++++++++++++++++++++++++++++++++++++++++++++++++
> tests/generic/927.out | 9 +++++
> tests/generic/928 | 86 ++++++++++++++++++++++++++++++++++++++++++++++++
> tests/generic/928.out | 10 ++++++
> tests/generic/group | 2 +
> 6 files changed, 196 insertions(+), 1 deletion(-)
> create mode 100755 tests/generic/927
> create mode 100644 tests/generic/927.out
> create mode 100755 tests/generic/928
> create mode 100644 tests/generic/928.out
>
>
> diff --git a/common/reflink b/common/reflink
> index 4ec390d..1363971 100644
> --- a/common/reflink
> +++ b/common/reflink
> @@ -107,7 +107,7 @@ _require_scratch_dedupe()
> _scratch_mount
> "$XFS_IO_PROG" -f -c "pwrite -S 0x61 0 65536" "$SCRATCH_MNT/file1" > /dev/null
> "$XFS_IO_PROG" -f -c "pwrite -S 0x61 0 65536" "$SCRATCH_MNT/file2" > /dev/null
> - testio="$("$XFS_IO_PROG" -f -c "dedupe $TEST_DIR/file1 0 0 65536" "$TEST_DIR/file2" 2>&1)"
> + testio="$("$XFS_IO_PROG" -f -c "dedupe $SCRATCH_MNT/file1 0 0 65536" "$SCRATCH_MNT/file2" 2>&1)"
> echo $testio | grep -q "Operation not supported" && \
> _notrun "Dedupe not supported by test filesystem type: $FSTYP"
> echo $testio | grep -q "Inappropriate ioctl for device" && \
I think this hunk belongs to a seperate patch.
Thanks,
Eryu
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-07-04 6:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 1:46 [PATCH v6 00/20] xfstests: minor fixes for the reflink/dedupe tests Darrick J. Wong
2016-06-17 1:46 ` [PATCH 01/20] xfs/104: don't enospc when ag metadata overhead grows Darrick J. Wong
2016-06-17 1:46 ` [PATCH 02/20] tests: don't put loop control files on the scratch mount Darrick J. Wong
2016-06-17 1:46 ` [PATCH 03/20] xfs: test copy-on-write leftover recovery Darrick J. Wong
2016-06-17 1:46 ` [PATCH 04/20] xfs: test per-ag allocation accounting during truncate-caused refcountbt expansion Darrick J. Wong
2016-06-17 1:46 ` [PATCH 05/20] reflink: test interaction with swap files Darrick J. Wong
2016-06-17 1:46 ` [PATCH 06/20] xfs: test rmap behavior when multiple bmbt records map to a single rmapbt record Darrick J. Wong
2016-06-17 1:46 ` [PATCH 07/20] reflink: test changing sharers of a block while keeping refcount the same Darrick J. Wong
2016-06-17 1:46 ` [PATCH 08/20] xfs/122: don't break on old xfsprogs Darrick J. Wong
2016-06-17 1:46 ` [PATCH 09/20] xfs/122: fix test output to reflect latest xfsprogs Darrick J. Wong
2016-06-17 1:47 ` [PATCH 10/20] xfs/122: list the new log redo items Darrick J. Wong
2016-06-17 1:47 ` [PATCH 11/20] xfs: inject errors at various parts of the deferred op completion Darrick J. Wong
2016-06-17 16:39 ` [PATCH v2 " Darrick J. Wong
2016-06-17 1:47 ` [PATCH 12/20] xfs/235: fix logic errors when checking rmap usage after failures Darrick J. Wong
2016-06-17 1:47 ` [PATCH 13/20] xfs/229: require 3GB of space Darrick J. Wong
2016-06-17 1:47 ` [PATCH 14/20] xfs: test clearing reflink inode flag Darrick J. Wong
2016-06-17 16:40 ` [PATCH v2 " Darrick J. Wong
2016-06-17 1:47 ` [PATCH 15/20] xfstests: fix unreferenced variables in generic/186 and generic/187 Darrick J. Wong
2016-06-17 1:47 ` [PATCH 16/20] reflink: test cross-mountpoint reflink and dedupe Darrick J. Wong
2016-07-04 6:51 ` Eryu Guan [this message]
2016-07-04 19:11 ` Darrick J. Wong
2016-06-17 1:47 ` [PATCH 17/20] generic/204: increase log size for rmap/reflink Darrick J. Wong
2016-06-17 1:47 ` [PATCH 18/20] xfs/128: use $XFS_FSR_PROG instead of xfs_fsr directly Darrick J. Wong
2016-06-17 1:48 ` [PATCH 19/20] xfs: run xfs_repair at the end of each test Darrick J. Wong
2016-07-05 3:56 ` Eryu Guan
2016-07-05 4:11 ` Darrick J. Wong
2016-07-06 23:13 ` Dave Chinner
2016-07-06 23:49 ` Darrick J. Wong
2016-06-17 1:48 ` [PATCH 20/20] xfs: scrub fs (if still mounted) at the end of the test Darrick J. Wong
2016-06-29 3:36 ` [PATCH 21/20] xfs/128: cycle_mount the scratch device, not the test device Darrick J. Wong
2016-07-05 4:31 ` [PATCH v6 00/20] xfstests: minor fixes for the reflink/dedupe tests Eryu Guan
2016-07-06 22:44 ` Darrick J. Wong
2016-07-13 5:28 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704065137.GW23649@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox