public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH v6 00/20] xfstests: minor fixes for the reflink/dedupe tests
Date: Tue, 5 Jul 2016 12:31:30 +0800	[thread overview]
Message-ID: <20160705043130.GF23649@eguan.usersys.redhat.com> (raw)
In-Reply-To: <146612796204.25024.18254357523133394284.stgit@birch.djwong.org>

Hi Darrick,

On Thu, Jun 16, 2016 at 06:46:02PM -0700, Darrick J. Wong wrote:
> Hi all,
> 
> This is the sixth revision of a patchset that adds to xfstests
> support for testing reverse-mappings of physical blocks to file and
> metadata (rmap); support for testing multiple file logical blocks to
> the same physical block (reflink); and implements the beginnings of
> online metadata scrubbing.
> 
> The first eight patches are in Eryu Guan's pull request on 2016-06-15.
> Those patches haven't changed, but they're not yet in the upstream
> repo.
> 
> If you're going to start using this mess, you probably ought to just
> pull from my github trees for kernel[1], xfsprogs[2], and xfstests[3].
> There are also updates for xfs-docs[4].  The kernel patches should
> apply to dchinner's for-next; xfsprogs patches to for-next; and
> xfstest to master.  The kernel git tree already has for-next included.
> 
> The patches have been xfstested with x64, i386, and armv7l--arm64,
> ppc64, and ppc64le no longer boot in qemu.  All three architectures
> pass all 'clone' group tests except xfs/128 (which is the swapext
> test), and AFAICT don't cause any new failures for the 'auto' group.
> 
> This is an extraordinary way to eat your data.  Enjoy! 
> Comments and questions are, as always, welcome.

I tested your xfstests patches with your kernel(HEAD f0b34b6 xfs: add
btree scrub tracepoints) and xfsprogs(HEAD 34bd754 xfs_scrub: create
online filesystem scrub program), with x86_64 host & 4k block size XFS.

A './check -g auto' run looked fine overall. Besides the comments I
replied to some patches, other common minor issues are:
- space indention in _cleanup not tab
- bare 'umount $SCRATCH_MNT' not _scratch_unmount
- whitespace issues in _test|scratch_inject_error

(I can fix all these minor issues at commit time, if you don't have
other major updates to these patches).

And the review of changes to xfs/122 needs help from other XFS
developers :) (09/20 and 10/20)

And besides the first 8 patches, 15/20 has been in upstream as well.

Thanks,
Eryu

P.S.
The failed tests I saw when testing with reflink-enabled kernel &
xfsprogs:

Failures: generic/054 generic/055 generic/108 generic/204 generic/356 generic/357 xfs/004 xfs/096 xfs/122 xfs/293

generic/108 generic/204 and xfs/004 are new failures compared to stock
kernel and xfsprogs (kernel 4.7-rc5, xfsprogs 4.7-rc1).

Just FYI.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2016-07-05  4:31 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17  1:46 [PATCH v6 00/20] xfstests: minor fixes for the reflink/dedupe tests Darrick J. Wong
2016-06-17  1:46 ` [PATCH 01/20] xfs/104: don't enospc when ag metadata overhead grows Darrick J. Wong
2016-06-17  1:46 ` [PATCH 02/20] tests: don't put loop control files on the scratch mount Darrick J. Wong
2016-06-17  1:46 ` [PATCH 03/20] xfs: test copy-on-write leftover recovery Darrick J. Wong
2016-06-17  1:46 ` [PATCH 04/20] xfs: test per-ag allocation accounting during truncate-caused refcountbt expansion Darrick J. Wong
2016-06-17  1:46 ` [PATCH 05/20] reflink: test interaction with swap files Darrick J. Wong
2016-06-17  1:46 ` [PATCH 06/20] xfs: test rmap behavior when multiple bmbt records map to a single rmapbt record Darrick J. Wong
2016-06-17  1:46 ` [PATCH 07/20] reflink: test changing sharers of a block while keeping refcount the same Darrick J. Wong
2016-06-17  1:46 ` [PATCH 08/20] xfs/122: don't break on old xfsprogs Darrick J. Wong
2016-06-17  1:46 ` [PATCH 09/20] xfs/122: fix test output to reflect latest xfsprogs Darrick J. Wong
2016-06-17  1:47 ` [PATCH 10/20] xfs/122: list the new log redo items Darrick J. Wong
2016-06-17  1:47 ` [PATCH 11/20] xfs: inject errors at various parts of the deferred op completion Darrick J. Wong
2016-06-17 16:39   ` [PATCH v2 " Darrick J. Wong
2016-06-17  1:47 ` [PATCH 12/20] xfs/235: fix logic errors when checking rmap usage after failures Darrick J. Wong
2016-06-17  1:47 ` [PATCH 13/20] xfs/229: require 3GB of space Darrick J. Wong
2016-06-17  1:47 ` [PATCH 14/20] xfs: test clearing reflink inode flag Darrick J. Wong
2016-06-17 16:40   ` [PATCH v2 " Darrick J. Wong
2016-06-17  1:47 ` [PATCH 15/20] xfstests: fix unreferenced variables in generic/186 and generic/187 Darrick J. Wong
2016-06-17  1:47 ` [PATCH 16/20] reflink: test cross-mountpoint reflink and dedupe Darrick J. Wong
2016-07-04  6:51   ` Eryu Guan
2016-07-04 19:11     ` Darrick J. Wong
2016-06-17  1:47 ` [PATCH 17/20] generic/204: increase log size for rmap/reflink Darrick J. Wong
2016-06-17  1:47 ` [PATCH 18/20] xfs/128: use $XFS_FSR_PROG instead of xfs_fsr directly Darrick J. Wong
2016-06-17  1:48 ` [PATCH 19/20] xfs: run xfs_repair at the end of each test Darrick J. Wong
2016-07-05  3:56   ` Eryu Guan
2016-07-05  4:11     ` Darrick J. Wong
2016-07-06 23:13       ` Dave Chinner
2016-07-06 23:49         ` Darrick J. Wong
2016-06-17  1:48 ` [PATCH 20/20] xfs: scrub fs (if still mounted) at the end of the test Darrick J. Wong
2016-06-29  3:36 ` [PATCH 21/20] xfs/128: cycle_mount the scratch device, not the test device Darrick J. Wong
2016-07-05  4:31 ` Eryu Guan [this message]
2016-07-06 22:44   ` [PATCH v6 00/20] xfstests: minor fixes for the reflink/dedupe tests Darrick J. Wong
2016-07-13  5:28   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705043130.GF23649@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox