From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH 0/3] serialize unmount against new buffer I/O
Date: Thu, 14 Jul 2016 13:29:25 -0400 [thread overview]
Message-ID: <20160714172924.GA25392@bfoster.bfoster> (raw)
In-Reply-To: <1468426595-35032-1-git-send-email-bfoster@redhat.com>
On Wed, Jul 13, 2016 at 12:16:32PM -0400, Brian Foster wrote:
> This is a rework of the directory readahead panic fix based on a buffer
> I/O count mechanism. See [1] for the original patch and subsequent
> discussion leading to the solution as constituted.
>
> This is split into multiple patches simply to break out some refactoring
> and special buffer exclusion from the accounting mechanism. This
> prevents the original problem (xfs/311) as well as passes an initial
> xfstests run.
>
FYI, I've hit an unmount hang with this while running generic/270. It
takes a few iterations to hit. I'm not sure if it's a race issue or more
of an explicit accounting issue, but I'll hold off on v2 until I can
track it down...
Brian
> Brian
>
> [1] http://oss.sgi.com/pipermail/xfs/2016-June/049946.html
>
> Brian Foster (3):
> xfs: helper to set flags on uncached buffer reads
> xfs: exclude never-released buffers from buftarg I/O accounting
> xfs: track and serialize in-flight async buffers against unmount
>
> fs/xfs/xfs_buf.c | 177 ++++++++++++++++++++++++++++++++++++++++-------------
> fs/xfs/xfs_buf.h | 8 +++
> fs/xfs/xfs_log.c | 4 +-
> fs/xfs/xfs_mount.c | 12 ++--
> 4 files changed, 151 insertions(+), 50 deletions(-)
>
> --
> 2.5.5
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-07-14 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 16:16 [PATCH 0/3] serialize unmount against new buffer I/O Brian Foster
2016-07-13 16:16 ` [PATCH 1/3] xfs: helper to set flags on uncached buffer reads Brian Foster
2016-07-14 0:01 ` Dave Chinner
2016-07-14 10:52 ` Brian Foster
2016-07-13 16:16 ` [PATCH 2/3] xfs: exclude never-released buffers from buftarg I/O accounting Brian Foster
2016-07-13 16:16 ` [PATCH 3/3] xfs: track and serialize in-flight async buffers against unmount Brian Foster
2016-07-14 0:05 ` Dave Chinner
2016-07-14 17:29 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714172924.GA25392@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox