From: Felix Janda <felix.janda@posteo.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH xfsprogs 2/2] linux.h: Define xfs_off_t as int64_t
Date: Mon, 1 Aug 2016 08:54:10 +0200 [thread overview]
Message-ID: <20160801065410.GA341@nyan> (raw)
In-Reply-To: <20160801062449.GB596@infradead.org>
Christoph Hellwig wrote:
> On Sat, Jul 30, 2016 at 03:37:37PM +0200, Felix Janda wrote:
> > int64_t is guaranteed to have the correct size and signedness and is
> > always avaible because linux.h has a <inttypes.h> include.
> >
> > Fixes compilation error "unkown type name 'off64_t'" on linux when the
> > public header <xfs.h> is included without _LARGEFILE64_SOURCE or
> > _GNU_SOURCE defined. This bug was introduced in commit
> > cb898f157f8410a03cf5f3400baa1df9e5eecd33.
>
> I would much prefer to just define _LARGEFILE64_SOURCE in linux.h..
Thanks for the suggestion, but that does not work if the system header
defining (or not) off64_t is included before the xfs headers.
---
Felix
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-01 6:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 13:37 [PATCH xfsprogs 2/2] linux.h: Define xfs_off_t as int64_t Felix Janda
2016-07-30 16:36 ` Eric Sandeen
2016-08-01 6:24 ` Christoph Hellwig
2016-08-01 6:54 ` Felix Janda [this message]
2016-08-04 0:47 ` Dave Chinner
2016-08-05 8:02 ` Felix Janda
2016-08-05 11:52 ` Dave Chinner
2016-08-05 13:09 ` Felix Janda
2016-08-05 22:44 ` Dave Chinner
2016-08-06 8:38 ` Felix Janda
2016-08-06 9:13 ` Felix Janda
2016-08-06 23:18 ` Dave Chinner
2016-08-07 7:09 ` Felix Janda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801065410.GA341@nyan \
--to=felix.janda@posteo.de \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox