From: Eryu Guan <eguan@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs: test attr_list_by_handle cursor iteration
Date: Thu, 4 Aug 2016 12:24:48 +0800 [thread overview]
Message-ID: <20160804042448.GR27776@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20160803225150.GC25565@birch.djwong.org>
On Wed, Aug 03, 2016 at 03:51:50PM -0700, Darrick J. Wong wrote:
> Apparently the XFS attr_list_by_handle ioctl has never actually copied
> the cursor contents back to user space, which means that iteration has
> never worked. Add a test case for this and see
> "xfs: in _attrlist_by_handle, copy the cursor back to userspace".
>
> v2: Use BULKSTAT_SINGLE for less confusion, fix build errors on RHEL6.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> .gitignore | 1
> src/Makefile | 3 -
> src/attr-list-by-handle-cursor-test.c | 185 +++++++++++++++++++++++++++++++++
> tests/xfs/700 | 64 +++++++++++
> tests/xfs/700.out | 5 +
> tests/xfs/group | 1
> 6 files changed, 258 insertions(+), 1 deletion(-)
> create mode 100644 src/attr-list-by-handle-cursor-test.c
> create mode 100755 tests/xfs/700
> create mode 100644 tests/xfs/700.out
>
[snip]
> +
> + read_handle_xattrs(&handle, false);
> + read_handle_xattrs(&handle, true);
I have to replace false/true with 0/1 to build it on RHEL6. I can fix it
at commit time if there's no other major updates.
Thanks,
Eryu
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-04 4:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 23:52 [PATCH] xfs: test attr_list_by_handle cursor iteration Darrick J. Wong
2016-08-03 4:47 ` Eryu Guan
2016-08-03 22:42 ` Darrick J. Wong
2016-08-03 22:51 ` [PATCH v2] " Darrick J. Wong
2016-08-04 4:24 ` Eryu Guan [this message]
2016-08-11 17:48 ` Christoph Hellwig
2016-08-12 3:14 ` Eryu Guan
2016-08-05 2:03 ` [PATCH v3] " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804042448.GR27776@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox