From: "Bill O'Donnell" <billodo@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_metadump: don't warn about unobfuscated log with -o
Date: Thu, 4 Aug 2016 11:13:18 -0500 [thread overview]
Message-ID: <20160804161318.GA739@redhat.com> (raw)
In-Reply-To: <541974d2-5877-a7ef-af3c-7d1a47e227c0@sandeen.net>
On Thu, Aug 04, 2016 at 10:51:12AM -0500, Eric Sandeen wrote:
> It makes no sense to warn about un-obfuscated logs
> when we asked xfs_metadump to not obfuscate metadata:
>
> # xfs_metadump -o /dev/loop2 bad.metadump
> xfs_metadump: Filesystem log is dirty; image will contain unobfuscated metadata in log.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
>
> diff --git a/db/metadump.c b/db/metadump.c
> index d7ff6e5..01a51c4 100644
> --- a/db/metadump.c
> +++ b/db/metadump.c
> @@ -2575,12 +2575,14 @@ copy_log(void)
> break;
> case 1:
> /* keep the dirty log */
> - print_warning(
> + if (obfuscate)
> + print_warning(
> _("Filesystem log is dirty; image will contain unobfuscated metadata in log."));
> break;
> case -1:
> /* log detection error */
> - print_warning(
> + if (obfuscate)
> + print_warning(
> _("Could not discern log; image will contain unobfuscated metadata in log."));
> break;
> }
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-08-04 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 15:51 [PATCH] xfs_metadump: don't warn about unobfuscated log with -o Eric Sandeen
2016-08-04 16:13 ` Bill O'Donnell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804161318.GA739@redhat.com \
--to=billodo@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox