From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 4EE487CA3 for ; Fri, 5 Aug 2016 06:52:44 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 01E7A304032 for ; Fri, 5 Aug 2016 04:52:43 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id ykSrSI16JtudYGRL for ; Fri, 05 Aug 2016 04:52:41 -0700 (PDT) Date: Fri, 5 Aug 2016 21:52:39 +1000 From: Dave Chinner Subject: Re: [PATCH xfsprogs 2/2] linux.h: Define xfs_off_t as int64_t Message-ID: <20160805115239.GH16044@dastard> References: <20160730133737.GB5895@nyan> <20160801062449.GB596@infradead.org> <20160801065410.GA341@nyan> <20160804004747.GZ16044@dastard> <20160805080241.GA749@nyan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160805080241.GA749@nyan> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Felix Janda Cc: Christoph Hellwig , xfs@oss.sgi.com On Fri, Aug 05, 2016 at 10:02:41AM +0200, Felix Janda wrote: > Dave Chinner wrote: > > On Mon, Aug 01, 2016 at 08:54:10AM +0200, Felix Janda wrote: > > > Christoph Hellwig wrote: > > > > On Sat, Jul 30, 2016 at 03:37:37PM +0200, Felix Janda wrote: > > > > > int64_t is guaranteed to have the correct size and signedness and is > > > > > always avaible because linux.h has a include. > > > > > > > > > > Fixes compilation error "unkown type name 'off64_t'" on linux when the > > > > > public header is included without _LARGEFILE64_SOURCE or > > > > > _GNU_SOURCE defined. This bug was introduced in commit > > > > > cb898f157f8410a03cf5f3400baa1df9e5eecd33. > > > > > > > > I would much prefer to just define _LARGEFILE64_SOURCE in linux.h.. > > > > > > Thanks for the suggestion, but that does not work if the system header > > > defining (or not) off64_t is included before the xfs headers. > > > > Which, to me, is a build bug in whatever code is including the xfs > > headers. Isn't it the responsibility of the build environment to > > ensure the dependencies of the libraries being used are correctly > > met? > > Every program using the xfs header is supposed to know that (only on > linux) since commit cb898f157f8410a03cf5f3400baa1df9e5eecd33 it is > necessary to define _LARGEFILE64_SOURCE or _GNU_SOURCE? Which, I'd say, most already do, because anything trying to use XFS ioctls needs to be 64 bit offset clean, even on 32 bit systems. I don't see any problem with requiring it when including a header that exposes ioctl interfaces with 64 bit file size/offset fields in them.... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs