Re: [PATCH xfsprogs 11/14] replace statvfs64 by equivalent statvfs

Felix Janda
2016-08-12T17:04:37Z

Christoph Hellwig wrote:
> On Tue, Aug 09, 2016 at 07:41:58PM +0200, Felix Janda wrote:
> > This patch removes the usage of statvfs64 and thus one of the problems
> > for Mac OS X. The other problem is solved by giving a suitable
> > definition of f_brsize. Note that this might collide with other uses
> > of f_brsize (if they exist). It might be cleaner to just check for Mac
> > OS X in xfs_fsr.c.
>
> Yes, that's probably better. Or simply not build fsr on MacOS given
> that there is no kernel XFS support anyway..

That second option sounds interesting. If fsr was not built on Mac OS X,
then commit 7141fc5b04905e (add *mntent abstraction) can basically be
reverted, simplifying the platform headers a bit.

Felix