From: Mike Frysinger <vapier@gentoo.org>
To: xfs@oss.sgi.com
Subject: [PATCH xfsprogs] libxcmd: link against used libs
Date: Tue, 9 Aug 2016 22:43:43 +0800 [thread overview]
Message-ID: <20160809144343.2228-1-vapier@gentoo.org> (raw)
Since this lib uses symbols from libxfs (platform_findsizes) and many
symbols from libblkid, link against both. Otherwise, the resulting
shared lib has missing symbols which makes linking against annoying.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
libxcmd/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libxcmd/Makefile b/libxcmd/Makefile
index aab8d6d63624..46ba138a37e2 100644
--- a/libxcmd/Makefile
+++ b/libxcmd/Makefile
@@ -12,6 +12,8 @@ LT_AGE = 0
CFILES = command.c input.c paths.c projects.c help.c quit.c topology.c
+LTLIBS = $(LIBXFS) $(LIBBLKID)
+
ifeq ($(HAVE_GETMNTENT),yes)
LCFLAGS += -DHAVE_GETMNTENT
endif
--
2.9.0
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2016-08-09 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 14:43 Mike Frysinger [this message]
2016-08-09 21:49 ` [PATCH xfsprogs] libxcmd: link against used libs Dave Chinner
2016-08-10 1:52 ` Mike Frysinger
2016-08-10 2:19 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809144343.2228-1-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox