From: Felix Janda <felix.janda@posteo.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH xfsprogs 01/14] configure: use AC_SYS_LARGEFILE
Date: Tue, 9 Aug 2016 19:41:05 +0200 [thread overview]
Message-ID: <20160809174105.GA5907@nyan> (raw)
In-Reply-To: <20160809073611.GC25647@infradead.org>
Thanks for reviewing the patch series!
> Does this also error out for libraries that don't support large
> off_t at all? I think that would be helpful to add if not there yet.
I do not quite understand. Do you refer to libraries using libxfs or
the external libraries used by xfsprogs?
For the latter, none of them exports interfaces using off_t. libblkid
has its own blkid_loff_t, which is defined as int64_t.
For the former, patch 13 forces any user of libxfs to enable
transparent LFS, by for example adding AC_SYS_LARGEFILE.
The approach of libblkid is the same as what I was suggesting in a
previous patch, but maybe it is good to break applications using
libxfs and not transparent LFS. For example this seems to be the case
for ceph. It has not enabled transparent LFS but mixes off_t and
off64_t. So it is likely that it has some LFS related runtime bugs on
32bit systems. If the xfs header included the off_t size check,
building ceph on 32bit systems would lead to a less subtle compile
failure.
Felix
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-09 17:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1470555003.git.felix.janda@posteo.de>
2016-08-06 10:45 ` [PATCH xfsprogs 03/14] replace fstat64 by equivalent fstat Felix Janda
2016-08-09 7:36 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 04/14] replace lstat64 by equivalent lstat Felix Janda
2016-08-09 7:37 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 05/14] replace stat64 by equivalent stat Felix Janda
2016-08-09 7:37 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 06/14] replace ftruncate64 by equivalent ftruncate Felix Janda
2016-08-09 7:38 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 07/14] replace lseek64 by equivalent lseek Felix Janda
2016-08-09 7:38 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 08/14] replace pread64 by equivalent pread Felix Janda
2016-08-09 7:38 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 09/14] replace pwrite64 by equivalent pwrite Felix Janda
2016-08-09 7:39 ` Christoph Hellwig
2016-08-06 10:52 ` [PATCH xfsprogs 12/14] replace off64_t by off_t outside of public headers Felix Janda
2016-08-09 7:40 ` Christoph Hellwig
2016-08-06 11:03 ` [PATCH xfsprogs 10/14] replace sendfile64 by equivalent sendfile Felix Janda
2016-08-09 7:39 ` Christoph Hellwig
2016-08-07 5:21 ` [PATCH xfsprogs 01/14] configure: use AC_SYS_LARGEFILE Felix Janda
2016-08-09 7:36 ` Christoph Hellwig
2016-08-09 17:41 ` Felix Janda [this message]
2016-08-12 2:57 ` Christoph Hellwig
2016-08-12 16:54 ` Felix Janda
2016-08-12 20:23 ` Christoph Hellwig
2016-08-07 5:28 ` [PATCH xfsprogs 02/14] remove unecessary definitions of _FILE_OFFSET_BITS Felix Janda
2016-08-09 7:36 ` Christoph Hellwig
2016-08-07 5:43 ` [PATCH xfsprogs 13/14] xfs.h: require transparent LFS Felix Janda
2016-08-09 7:41 ` Christoph Hellwig
2016-08-09 18:03 ` [PATCHv2 " Felix Janda
2016-08-12 2:56 ` Christoph Hellwig
2016-08-07 5:52 ` [PATCH xfsprogs 14/14] platform: remove use of off64_t Felix Janda
2016-08-09 7:41 ` Christoph Hellwig
2016-08-07 6:24 ` [PATCH xfsprogs 11/14] replace statvfs64 by equivalent statvfs Felix Janda
2016-08-09 7:40 ` Christoph Hellwig
2016-08-09 17:41 ` Felix Janda
2016-08-12 2:57 ` Christoph Hellwig
2016-08-12 17:03 ` Felix Janda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809174105.GA5907@nyan \
--to=felix.janda@posteo.de \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox