Re: [PATCH xfsprogs] libxcmd: link against used libs

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1020 bytes --]

On 10 Aug 2016 07:49, Dave Chinner wrote:
> On Tue, Aug 09, 2016 at 10:43:43PM +0800, Mike Frysinger wrote:
> > Since this lib uses symbols from libxfs (platform_findsizes) and many
> > symbols from libblkid, link against both.  Otherwise, the resulting
> > shared lib has missing symbols which makes linking against annoying.
> 
> libxcmd is an internal library, linked directly into the xfsprogs
> binaries. It is never shipped or used outside xfsprogs, so what is
> trying to use libxcmd as a shared library that doesn't also link
> against libblkid or libxfs?

shouldn't internal libs still have coherent linkage ?  otherwise you
cause problems even internally for xfs -- any other libs or progs that
link against libxcmd have to list all the libs that libxcmd happen to
use itself.  it also means that you get correct link order which is
otherwise not guaranteed.  e.g. just because you say libxfs needs to
use libblkid doesn't mean the linker must put that after libxcmd in
the link list.
-mike

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs