From: Felix Janda <felix.janda@posteo.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH xfsprogs 11/14] replace statvfs64 by equivalent statvfs
Date: Fri, 12 Aug 2016 19:03:36 +0200 [thread overview]
Message-ID: <20160812170336.GB367@nyan> (raw)
In-Reply-To: <20160812025703.GC10701@infradead.org>
Christoph Hellwig wrote:
> On Tue, Aug 09, 2016 at 07:41:58PM +0200, Felix Janda wrote:
> > This patch removes the usage of statvfs64 and thus one of the problems
> > for Mac OS X. The other problem is solved by giving a suitable
> > definition of f_brsize. Note that this might collide with other uses
> > of f_brsize (if they exist). It might be cleaner to just check for Mac
> > OS X in xfs_fsr.c.
>
> Yes, that's probably better. Or simply not build fsr on MacOS given
> that there is no kernel XFS support anyway..
That second option sounds interesting. If fsr was not built on Mac OS X,
then commit 7141fc5b04905e (add *mntent abstraction) can basically be
reverted, simplifying the platform headers a bit.
Felix
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-08-12 17:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1470555003.git.felix.janda@posteo.de>
2016-08-06 10:45 ` [PATCH xfsprogs 03/14] replace fstat64 by equivalent fstat Felix Janda
2016-08-09 7:36 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 04/14] replace lstat64 by equivalent lstat Felix Janda
2016-08-09 7:37 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 05/14] replace stat64 by equivalent stat Felix Janda
2016-08-09 7:37 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 06/14] replace ftruncate64 by equivalent ftruncate Felix Janda
2016-08-09 7:38 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 07/14] replace lseek64 by equivalent lseek Felix Janda
2016-08-09 7:38 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 08/14] replace pread64 by equivalent pread Felix Janda
2016-08-09 7:38 ` Christoph Hellwig
2016-08-06 10:45 ` [PATCH xfsprogs 09/14] replace pwrite64 by equivalent pwrite Felix Janda
2016-08-09 7:39 ` Christoph Hellwig
2016-08-06 10:52 ` [PATCH xfsprogs 12/14] replace off64_t by off_t outside of public headers Felix Janda
2016-08-09 7:40 ` Christoph Hellwig
2016-08-06 11:03 ` [PATCH xfsprogs 10/14] replace sendfile64 by equivalent sendfile Felix Janda
2016-08-09 7:39 ` Christoph Hellwig
2016-08-07 5:21 ` [PATCH xfsprogs 01/14] configure: use AC_SYS_LARGEFILE Felix Janda
2016-08-09 7:36 ` Christoph Hellwig
2016-08-09 17:41 ` Felix Janda
2016-08-12 2:57 ` Christoph Hellwig
2016-08-12 16:54 ` Felix Janda
2016-08-12 20:23 ` Christoph Hellwig
2016-08-07 5:28 ` [PATCH xfsprogs 02/14] remove unecessary definitions of _FILE_OFFSET_BITS Felix Janda
2016-08-09 7:36 ` Christoph Hellwig
2016-08-07 5:43 ` [PATCH xfsprogs 13/14] xfs.h: require transparent LFS Felix Janda
2016-08-09 7:41 ` Christoph Hellwig
2016-08-09 18:03 ` [PATCHv2 " Felix Janda
2016-08-12 2:56 ` Christoph Hellwig
2016-08-07 5:52 ` [PATCH xfsprogs 14/14] platform: remove use of off64_t Felix Janda
2016-08-09 7:41 ` Christoph Hellwig
2016-08-07 6:24 ` [PATCH xfsprogs 11/14] replace statvfs64 by equivalent statvfs Felix Janda
2016-08-09 7:40 ` Christoph Hellwig
2016-08-09 17:41 ` Felix Janda
2016-08-12 2:57 ` Christoph Hellwig
2016-08-12 17:03 ` Felix Janda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812170336.GB367@nyan \
--to=felix.janda@posteo.de \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox