Re: [PATCHv2 xfsprogs 00/14] Convert from off64_t to off_t

Christoph Hellwig
2016-08-25T08:04:10Z

On Wed, Aug 24, 2016 at 10:47:46PM +0200, Felix Janda wrote:
> > screws up xfstests because it changes all the error messages
> > that are output to stderr and captured by the test harness.
> > There are quite a few tests that this causes failures for,
> > and because it's stderr, it's not as simple as just adding a new
> > filter to do 'sed -e "s/^\(.*\)64\(: .*$\)/\1\2/"' on stderr.
>
> Thanks for testing!
>
> I can rework the patches to leave stderr unchanged. I guess that this
> is preferable as opposed to updating the output expected by xfstests
> since xfstests should be usable with both old and new xfsprogs.

I would prefer to change the output if we can find a good way to
filter it. I suspect the issues are things like perror lines
which would look odd if we leave the 64 back in.