From: Dave Chinner <david@fromorbit.com>
To: Bill O'Donnell <billodo@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 2/3] xfs_quota: changes to accomodate hoisted ioctl defs
Date: Mon, 22 Aug 2016 11:18:12 +1000 [thread overview]
Message-ID: <20160822011812.GP19025@dastard> (raw)
In-Reply-To: <1471356998-2876-3-git-send-email-billodo@redhat.com>
On Tue, Aug 16, 2016 at 09:16:37AM -0500, Bill O'Donnell wrote:
> The kernel commit to make the ioctl promotion (334e580a6f) moved
> the definitions for the XFS ioctl to uapi/linux/fs.h for the
> following reason:
>
> Hoist the ioctl definitions for the XFS_IOC_FS[SG]SETXATTR API
> from fs/xfs/libxfs/xfs_fs.h to include/uapi/linux/fs.h so that
> the ioctls can be used by all filesystems, not just XFS. This
> enables (initially) ext4 to use the ioctl to set project IDs on
> inodes.
>
> This means we now need to handle this change in userspace as the
> uapi/linux/fs.h file may not contain the definitions (i.e. new
> xfsprogs/ old linux uapi files) xfsprogs needs to build. Hence we
> need to massage the definition in xfs_fs.h to take the values from
> the system header if it exists, otherwise keep the old definitions
> for compatibility and platforms other than linux..
>
> This patch was originally submitted by Dave Chinner
> (http://oss.sgi.com/archives/xfs/2016-02/msg00108.html)
>
> Resubmitting with changes to accomodate upstream changes since
> initial submission.
This is unnecessary - the "include local version" changes were made
to the platform headers (e.g. include/linux.h) in commit 83f4b5a
("xfs_fs.h: XFS_IOC_FS[SG]SETXATTR to FS_IOC_FS[SG]ETXATTR
promotion").
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-22 1:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 14:16 [PATCH v2 0/3] xfs_quota: allow operation on ext4 for project quotas Bill O'Donnell
2016-08-16 14:16 ` [PATCH v2 1/3] xfs_quota: add capabilities for use on ext4 Bill O'Donnell
2016-08-22 1:47 ` Dave Chinner
2016-08-22 16:02 ` Bill O'Donnell
2016-08-23 0:09 ` Dave Chinner
2016-08-23 0:24 ` Bill O'Donnell
2016-08-16 14:16 ` [PATCH v2 2/3] xfs_quota: changes to accomodate hoisted ioctl defs Bill O'Donnell
2016-08-22 1:18 ` Dave Chinner [this message]
2016-08-22 13:16 ` Bill O'Donnell
2016-08-16 14:16 ` [PATCH v2 3/3] xfs_quota: additional changes to allow use on ext4 Bill O'Donnell
2016-08-22 2:06 ` Dave Chinner
2016-08-22 3:34 ` Eric Sandeen
2016-08-22 4:46 ` Eric Sandeen
2016-08-22 5:34 ` Dave Chinner
2016-08-22 13:20 ` Bill O'Donnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822011812.GP19025@dastard \
--to=david@fromorbit.com \
--cc=billodo@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox