From: Dave Chinner <david@fromorbit.com>
To: Bill O'Donnell <billodo@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 1/3] xfs_quota: add capabilities for use on ext4
Date: Mon, 22 Aug 2016 11:47:42 +1000 [thread overview]
Message-ID: <20160822014742.GQ19025@dastard> (raw)
In-Reply-To: <1471356998-2876-2-git-send-email-billodo@redhat.com>
On Tue, Aug 16, 2016 at 09:16:36AM -0500, Bill O'Donnell wrote:
> This allows xfs_quota to be used on ext4 for project quota testing
> in xfstests.
>
> This patch was originally submitted by Dave Chinner
> (http://oss.sgi.com/archives/xfs/2016-02/msg00131.html)
>
> Resubmitting with the following change:
> quota/init.c: correct logic error in loop contained in init_args_command()
> function (lines 85-91).
What logic error?
Commit messages like this really don't tell the reader anything
about what is different the original patch. I've had to go archive
spelunking to work out what is different, and I'm still not sure
what the logic error you fixed is....
And, FWIW, whilst spelunking, I noticed that Eric's last review
comments on my original patch:
Looks ok, but now with the new option:
1) needs a manpage update
2) usage() should be updated to include -f
3) and I just noticed,
_("foreign mount active, %s command is for XFS filesystems only\n"),
seems kind of unclear; maybe just
_("%s command is for XFS filesystems only\n"),
have not been addressed by this update.
Can you please add these these changes, update the commit message
and resubmit?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-22 1:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 14:16 [PATCH v2 0/3] xfs_quota: allow operation on ext4 for project quotas Bill O'Donnell
2016-08-16 14:16 ` [PATCH v2 1/3] xfs_quota: add capabilities for use on ext4 Bill O'Donnell
2016-08-22 1:47 ` Dave Chinner [this message]
2016-08-22 16:02 ` Bill O'Donnell
2016-08-23 0:09 ` Dave Chinner
2016-08-23 0:24 ` Bill O'Donnell
2016-08-16 14:16 ` [PATCH v2 2/3] xfs_quota: changes to accomodate hoisted ioctl defs Bill O'Donnell
2016-08-22 1:18 ` Dave Chinner
2016-08-22 13:16 ` Bill O'Donnell
2016-08-16 14:16 ` [PATCH v2 3/3] xfs_quota: additional changes to allow use on ext4 Bill O'Donnell
2016-08-22 2:06 ` Dave Chinner
2016-08-22 3:34 ` Eric Sandeen
2016-08-22 4:46 ` Eric Sandeen
2016-08-22 5:34 ` Dave Chinner
2016-08-22 13:20 ` Bill O'Donnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822014742.GQ19025@dastard \
--to=david@fromorbit.com \
--cc=billodo@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox