From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 3/3] xfs_quota: additional changes to allow use on ext4
Date: Mon, 22 Aug 2016 15:34:55 +1000 [thread overview]
Message-ID: <20160822053455.GT19025@dastard> (raw)
In-Reply-To: <8c1b4044-ff69-f891-a4f4-b302bd3bfef3@sandeen.net>
On Sun, Aug 21, 2016 at 11:46:14PM -0500, Eric Sandeen wrote:
> On 8/21/16 10:34 PM, Eric Sandeen wrote:
> > On 8/21/16 9:06 PM, Dave Chinner wrote:
> >> On Tue, Aug 16, 2016 at 09:16:38AM -0500, Bill O'Donnell wrote:
>
> ...
>
> >> static int
> >> init_check_command(
> >> const cmdinfo_t *ct)
> >> {
> >> if (!fspath)
> >> return 1;
> >>
> >> /* Always run commands that we are told to skip here */
> >> if (ct->flags & CMD_SKIP_CHECK)
> >> return 1;
> >>
> >> /* if it's an XFS filesystem, always run the command */
> >> if (!(fs_path->fs_flags & FS_FOREIGN))
> >> return 1;
> >
> > Sorry for the late review; thanks for getting on it, Dave - but,
> > isn't "foreign ok" exactly == "skip check?"
> >
> > The only check that gets skipped is the foreign check, so just
> > setting FOREIGN_OK seems to accomplish the same thing without
> > more flag complexity, no?
>
> Oh, the subliminal brain reminded me that we want to be able to
> issue help or quit whether or not we had the "-f" flag, regardless
> of the filesystem, and that "foreign" isn't ok unless the -f flag
> is set, so we do need a class of "always works" commands.
Right, but that was something that was done in patch 1/3. I pointed
out that no mention of it was made in the cmmit message there....
> I guess that was the point of the patch, but I suppose some clarity
> in comments or commitlog would help slow people like me. ;)
Right. better explanations needed all round :P
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-22 5:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 14:16 [PATCH v2 0/3] xfs_quota: allow operation on ext4 for project quotas Bill O'Donnell
2016-08-16 14:16 ` [PATCH v2 1/3] xfs_quota: add capabilities for use on ext4 Bill O'Donnell
2016-08-22 1:47 ` Dave Chinner
2016-08-22 16:02 ` Bill O'Donnell
2016-08-23 0:09 ` Dave Chinner
2016-08-23 0:24 ` Bill O'Donnell
2016-08-16 14:16 ` [PATCH v2 2/3] xfs_quota: changes to accomodate hoisted ioctl defs Bill O'Donnell
2016-08-22 1:18 ` Dave Chinner
2016-08-22 13:16 ` Bill O'Donnell
2016-08-16 14:16 ` [PATCH v2 3/3] xfs_quota: additional changes to allow use on ext4 Bill O'Donnell
2016-08-22 2:06 ` Dave Chinner
2016-08-22 3:34 ` Eric Sandeen
2016-08-22 4:46 ` Eric Sandeen
2016-08-22 5:34 ` Dave Chinner [this message]
2016-08-22 13:20 ` Bill O'Donnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822053455.GT19025@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox