From: Carlos Maiolino <cmaiolino@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: disallow mounting of realtime + rmap filesystems
Date: Mon, 22 Aug 2016 04:35:54 -0400 [thread overview]
Message-ID: <20160822083554.GA8035@redhat.com> (raw)
In-Reply-To: <20160819203207.GE8268@birch.djwong.org>
On Fri, Aug 19, 2016 at 01:32:07PM -0700, Darrick J. Wong wrote:
> Since the kernel doesn't currently support the realtime rmapbt,
> don't allow such filesystems to be mounted. Support will appear
> in a future release.
>
Makes sense to me, you can add:
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_super.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 24ef83e..fd6be45 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1574,9 +1574,16 @@ xfs_fs_fill_super(
> }
> }
>
> - if (xfs_sb_version_hasrmapbt(&mp->m_sb))
> + if (xfs_sb_version_hasrmapbt(&mp->m_sb)) {
> + if (mp->m_sb.sb_rblocks) {
> + xfs_alert(mp,
> + "EXPERIMENTAL reverse mapping btree not compatible with realtime device!");
> + error = -EINVAL;
> + goto out_filestream_unmount;
> + }
> xfs_alert(mp,
> "EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!");
> + }
>
> error = xfs_mountfs(mp);
> if (error)
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-22 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 20:32 [PATCH] xfs: disallow mounting of realtime + rmap filesystems Darrick J. Wong
2016-08-22 8:35 ` Carlos Maiolino [this message]
2016-08-25 8:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822083554.GA8035@redhat.com \
--to=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox