* [PATCH] xfs: disallow mounting of realtime + rmap filesystems
@ 2016-08-19 20:32 Darrick J. Wong
2016-08-22 8:35 ` Carlos Maiolino
2016-08-25 8:05 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Darrick J. Wong @ 2016-08-19 20:32 UTC (permalink / raw)
To: Dave Chinner; +Cc: linux-xfs, xfs
Since the kernel doesn't currently support the realtime rmapbt,
don't allow such filesystems to be mounted. Support will appear
in a future release.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_super.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 24ef83e..fd6be45 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1574,9 +1574,16 @@ xfs_fs_fill_super(
}
}
- if (xfs_sb_version_hasrmapbt(&mp->m_sb))
+ if (xfs_sb_version_hasrmapbt(&mp->m_sb)) {
+ if (mp->m_sb.sb_rblocks) {
+ xfs_alert(mp,
+ "EXPERIMENTAL reverse mapping btree not compatible with realtime device!");
+ error = -EINVAL;
+ goto out_filestream_unmount;
+ }
xfs_alert(mp,
"EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!");
+ }
error = xfs_mountfs(mp);
if (error)
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: disallow mounting of realtime + rmap filesystems
2016-08-19 20:32 [PATCH] xfs: disallow mounting of realtime + rmap filesystems Darrick J. Wong
@ 2016-08-22 8:35 ` Carlos Maiolino
2016-08-25 8:05 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Carlos Maiolino @ 2016-08-22 8:35 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: linux-xfs, xfs
On Fri, Aug 19, 2016 at 01:32:07PM -0700, Darrick J. Wong wrote:
> Since the kernel doesn't currently support the realtime rmapbt,
> don't allow such filesystems to be mounted. Support will appear
> in a future release.
>
Makes sense to me, you can add:
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_super.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 24ef83e..fd6be45 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1574,9 +1574,16 @@ xfs_fs_fill_super(
> }
> }
>
> - if (xfs_sb_version_hasrmapbt(&mp->m_sb))
> + if (xfs_sb_version_hasrmapbt(&mp->m_sb)) {
> + if (mp->m_sb.sb_rblocks) {
> + xfs_alert(mp,
> + "EXPERIMENTAL reverse mapping btree not compatible with realtime device!");
> + error = -EINVAL;
> + goto out_filestream_unmount;
> + }
> xfs_alert(mp,
> "EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!");
> + }
>
> error = xfs_mountfs(mp);
> if (error)
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: disallow mounting of realtime + rmap filesystems
2016-08-19 20:32 [PATCH] xfs: disallow mounting of realtime + rmap filesystems Darrick J. Wong
2016-08-22 8:35 ` Carlos Maiolino
@ 2016-08-25 8:05 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2016-08-25 8:05 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: linux-xfs, xfs
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-25 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-19 20:32 [PATCH] xfs: disallow mounting of realtime + rmap filesystems Darrick J. Wong
2016-08-22 8:35 ` Carlos Maiolino
2016-08-25 8:05 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox