From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Felix Janda <felix.janda@posteo.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: kill __uint*_t and __int*_t
Date: Wed, 24 Aug 2016 08:35:00 +1000 [thread overview]
Message-ID: <20160823223500.GZ19025@dastard> (raw)
In-Reply-To: <20160809083332.GA1489@infradead.org>
On Tue, Aug 09, 2016 at 01:33:32AM -0700, Christoph Hellwig wrote:
> On Sun, Aug 07, 2016 at 07:38:35PM +0200, Felix Janda wrote:
> > Replace them by the more widely used uint*_t and int*_t.
> >
> > Signed-off-by: Felix Janda <felix.janda@posteo.de>
> > ---
> > This patch is essentially a global
> > 'sed -i "s/__\(u*\)int\([0-9]*\)_t/\1int\2_t/"'. The only other changes
> > are whitespace changes and removing the now unecessary type definitions.
> >
> > Running 'sed "s/^.//"' on the patch might be useful for checking that
> > I didn't mess up the indentation.
>
> If everyone is fine using (u)int*_t over s*/u* this looks good. I'd
> have a slight preference for s*/u* as in the rest of the kernel, but
> either way getting rid of our crazy __ types is a good thing.
Don't really care that much. I'd prefer (marginally) to go with the
(u)int*_t types as userspace then doesn't need a set of typedefs in
the platform headers to support the kernel specific types in libxfs
code....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-23 22:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 17:38 [PATCH] xfs: kill __uint*_t and __int*_t Felix Janda
2016-08-09 8:33 ` Christoph Hellwig
2016-08-23 22:35 ` Dave Chinner [this message]
2016-08-23 23:26 ` Darrick J. Wong
2016-08-24 21:07 ` Felix Janda
2017-04-20 16:41 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823223500.GZ19025@dastard \
--to=david@fromorbit.com \
--cc=felix.janda@posteo.de \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox