From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id ACED17CA0 for ; Tue, 23 Aug 2016 20:55:56 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 22BAEAC006 for ; Tue, 23 Aug 2016 18:55:55 -0700 (PDT) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id FzGhIOxB9TNvcJpN for ; Tue, 23 Aug 2016 18:55:53 -0700 (PDT) Date: Wed, 24 Aug 2016 11:55:51 +1000 From: Dave Chinner Subject: Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors. Message-ID: <20160824015551.GB19025@dastard> References: <1471967653-2561-1-git-send-email-asavkov@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1471967653-2561-1-git-send-email-asavkov@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Artem Savkov Cc: Eric Sandeen , linux-kernel@vger.kernel.org, xfs@oss.sgi.com On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > Commit "xfs: only return -errno or success from attr ->put_listent" changes the Please quote commits in --oneline format in changelogs - it makes it much easier to find the change you are refering to if there is both a commit ID and the text string in the commit message. (i.e. text string confirms the commit id is the one you meant to quote). commit 2a6fba6 ("xfs: only return -errno or success from attr ->put_listent") is the one you are refering to here, right? > returnvalue of __xfs_xattr_put_listen to 0 in case when there is insufficient > space in the buffer assuming that setting context->count to -1 would be enough, > but all of the ->put_listent callers only check seen_enough. This results in > a failed assertion: > XFS: Assertion failed: context->count >= 0, file: fs/xfs/xfs_xattr.c, line: 175 > in insufficient buffer size case. You have a test case? Can you turn it into an xfstest? We really need regression tests that cover issues like this.... > Signed-off-by: Artem Savkov > --- > fs/xfs/xfs_xattr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c > index ea62245..6290093 100644 > --- a/fs/xfs/xfs_xattr.c > +++ b/fs/xfs/xfs_xattr.c > @@ -147,6 +147,7 @@ __xfs_xattr_put_listent( > arraytop = context->count + prefix_len + namelen + 1; > if (arraytop > context->firstu) { > context->count = -1; /* insufficient space */ > + context->seen_enough = 1; > return 0; > } > offset = (char *)context->alist + context->count; Looks sane, though I don't know how to test it yet.... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs