From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 34A487CA0 for ; Wed, 24 Aug 2016 16:09:33 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 9F66AAC001 for ; Wed, 24 Aug 2016 14:09:29 -0700 (PDT) Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by cuda.sgi.com with ESMTP id UDCzk1x1OSQCH36A (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 24 Aug 2016 14:09:26 -0700 (PDT) Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 2B235209DD for ; Wed, 24 Aug 2016 23:09:24 +0200 (CEST) Date: Wed, 24 Aug 2016 23:07:49 +0200 From: Felix Janda Subject: Re: [PATCH] xfs: kill __uint*_t and __int*_t Message-ID: <20160824210749.GB25162@nyan> References: <20160807173835.GA20839@nyan> <20160809083332.GA1489@infradead.org> <20160823223500.GZ19025@dastard> <20160823232640.GG8268@birch.djwong.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160823232640.GG8268@birch.djwong.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: "Darrick J. Wong" Cc: Christoph Hellwig , xfs@oss.sgi.com Darrick J. Wong wrote: > On Wed, Aug 24, 2016 at 08:35:00AM +1000, Dave Chinner wrote: > > On Tue, Aug 09, 2016 at 01:33:32AM -0700, Christoph Hellwig wrote: > > > On Sun, Aug 07, 2016 at 07:38:35PM +0200, Felix Janda wrote: > > > > Replace them by the more widely used uint*_t and int*_t. > > > > > > > > Signed-off-by: Felix Janda > > > > --- > > > > This patch is essentially a global > > > > 'sed -i "s/__\(u*\)int\([0-9]*\)_t/\1int\2_t/"'. The only other changes > > > > are whitespace changes and removing the now unecessary type definitions. > > > > > > > > Running 'sed "s/^.//"' on the patch might be useful for checking that > > > > I didn't mess up the indentation. > > > > > > If everyone is fine using (u)int*_t over s*/u* this looks good. I'd > > > have a slight preference for s*/u* as in the rest of the kernel, but > > > either way getting rid of our crazy __ types is a good thing. > > > > Don't really care that much. I'd prefer (marginally) to go with the > > (u)int*_t types as userspace then doesn't need a set of typedefs in > > the platform headers to support the kernel specific types in libxfs > > code.... > > I don't mind moving from __uintXX_t to uintXX_t so long as the changes > land in the kernel and xfsprogs at the same time. When everyone is ok with the changes, I'll prepare patches for both of them. --Felix _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs