From: Christoph Hellwig <hch@infradead.org>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/033: source mkfs output again if isize less than 512
Date: Thu, 25 Aug 2016 01:06:31 -0700 [thread overview]
Message-ID: <20160825080631.GD28747@infradead.org> (raw)
In-Reply-To: <1471790859-26077-1-git-send-email-zlang@redhat.com>
On Sun, Aug 21, 2016 at 10:47:39PM +0800, Zorro Lang wrote:
> I moved the mkfs_xfs output to /dev/null, because:
> 1. I think it's not necessary.
> 2. The case maybe do and output mkfs once or twice(not sure). So it'll be
> hard to keep consistent golden image.
I agree. If for some reaoson we care about the info we should just
do a xfs_info later, but I can't see one.
But with this change I think we can also consolidate the output files
into a single 033.out file, can't we?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-08-25 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 14:47 [PATCH] xfs/033: source mkfs output again if isize less than 512 Zorro Lang
2016-08-25 8:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825080631.GD28747@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=xfs@oss.sgi.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox