linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/4] xfs: make xfs_inode_set_eofblocks_tag cheaper for the common case
Date: Fri, 26 Aug 2016 12:02:09 -0400	[thread overview]
Message-ID: <20160826160209.GB17728@bfoster.bfoster> (raw)
In-Reply-To: <20160826142616.GA21535@lst.de>

On Fri, Aug 26, 2016 at 04:26:16PM +0200, Christoph Hellwig wrote:
> On Thu, Aug 25, 2016 at 08:38:09AM -0400, Brian Foster wrote:
> > I'm guessing the lockless check is intentional, but is that really
> > necessary? E.g., it doesn't seem like using ->i_flags_lock
> > unconditionally should affect performance in the way the AG lock or
> > radix tree work does, particularly since we're already holding
> > IOLOCK_EXCL in the current implementation. I could be wrong, but FWIW,
> > we do already have xfs_iflags_test_and_set() sitting around as well...
> 
> I don't think taking it should be too bad, but given the ops ordering
> it also seems entirely pointless to even take it.
> 

Then why are we taking it? I assumed it at least served as a memory
barrier...

Brian

> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-08-26 16:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-21 21:51 iomap write fixes Christoph Hellwig
2016-08-21 21:51 ` [PATCH 1/4] xfs: move xfs_bmbt_to_iomap up Christoph Hellwig
2016-08-25 12:38   ` Brian Foster
2016-08-21 21:51 ` [PATCH 2/4] xfs: factor our a helper to calculate the EOF alignment Christoph Hellwig
2016-08-25 12:38   ` Brian Foster
2016-08-21 21:51 ` [PATCH 3/4] xfs: make xfs_inode_set_eofblocks_tag cheaper for the common case Christoph Hellwig
2016-08-25 12:38   ` Brian Foster
2016-08-26 14:26     ` Christoph Hellwig
2016-08-26 16:02       ` Brian Foster [this message]
2016-08-30 14:40         ` Christoph Hellwig
2016-08-30 23:03           ` Dave Chinner
2016-08-21 21:51 ` [PATCH 4/4] xfs: rewrite and optimize the delalloc write path Christoph Hellwig
2016-08-25 14:37   ` Brian Foster
2016-08-26 14:33     ` Christoph Hellwig
2016-08-26 16:03       ` Brian Foster
2016-08-26 16:07         ` Brian Foster
2016-08-30 14:44           ` Christoph Hellwig
2016-08-30 20:28           ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160826160209.GB17728@bfoster.bfoster \
    --to=bfoster@redhat.com \
    --cc=hch@lst.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).